Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: pkg/analysis_server/lib/src/analysis_server.dart

Issue 1417483006: Support for searching files by import/export/part URIs and library identifiers. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/analysis_server.dart
diff --git a/pkg/analysis_server/lib/src/analysis_server.dart b/pkg/analysis_server/lib/src/analysis_server.dart
index 3c6eea7e21eff9dca02bb4c353a96e67d4bf93ae..62adc4fe666157562609db117ed1863bce667929 100644
--- a/pkg/analysis_server/lib/src/analysis_server.dart
+++ b/pkg/analysis_server/lib/src/analysis_server.dart
@@ -573,6 +573,11 @@ class AnalysisServer {
if (node is LibraryIdentifier) {
node = node.parent;
}
+ // TODO(scheglov) It seems now that resolving URI to the imported library
+ // is a mistake. Remove this from ElementLocator.
Brian Wilkerson 2015/10/20 14:57:15 Why is it a mistake?
+ if (node is StringLiteral) {
+ continue;
+ }
Element element = ElementLocator.locate(node);
if (node is SimpleIdentifier && element is PrefixElement) {
element = getImportElement(node);

Powered by Google App Engine
This is Rietveld 408576698