Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 1417363002: Revert of Use FrameSelection::selectedText where possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index 16f3f9202ef864bab64936b924b6ec4ae2e2895c..56619e311285df3bc84cb4858f117d5a55c5e954 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -1241,7 +1241,11 @@
if (pluginContainer)
return pluginContainer->plugin()->selectionAsText();
- String text = frame()->selection().selectedText(TextIteratorEmitsObjectReplacementCharacter);
+ const EphemeralRange range = frame()->selection().selection().toNormalizedEphemeralRange();
+ if (range.isNull())
+ return WebString();
+
+ String text = plainText(range, TextIteratorEmitsObjectReplacementCharacter);
#if OS(WIN)
replaceNewlinesWithWindowsStyleNewlines(text);
#endif
@@ -1255,7 +1259,11 @@
if (pluginContainer)
return pluginContainer->plugin()->selectionAsMarkup();
- return frame()->selection().selectedHTMLForClipboard();
+ const EphemeralRange range = frame()->selection().selection().toNormalizedEphemeralRange();
+ if (range.isNull())
+ return WebString();
+
+ return createMarkup(range.startPosition(), range.endPosition(), AnnotateForInterchange, ConvertBlocksToInlines::NotConvert, ResolveNonLocalURLs);
}
void WebLocalFrameImpl::selectWordAroundPosition(LocalFrame* frame, VisiblePosition position)
« no previous file with comments | « third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698