Tests: Simplify SequencedWorkerPoolOwner, call Shutdown on destructor.

Tests: Simplify SequencedWorkerPoolOwner, call Shutdown on destructor.

Also ports remaining tests using raw SWPs to use SWPOwner.

BUG=450228
Committed: https://crrev.com/fc939726c283e34112d9bc845a39460410fe9cd9
Cr-Commit-Position: refs/heads/master@{#362805}

[tommycli, 2015-11-04 22:48:46]

Description was changed from

==========
Tests: Simplify SequencedWorkerPoolOwner, call Shutdown on destructor.

BUG=
==========

to

==========
Tests: Simplify SequencedWorkerPoolOwner, call Shutdown on destructor.

Also ports remaining tests using raw SWPs to use SWPOwner.

BUG=450228
==========

[tommycli, 2015-11-05 00:39:07]

tommycli@chromium.org changed reviewers:
+ jam@chromium.org

[tommycli, 2015-11-05 00:39:08]

jam: PTAL, thanks!

[jam, 2015-11-05 17:06:03]

On 2015/11/05 00:39:08, tommycli wrote:
> jam: PTAL, thanks!

you should send this to an owner in base/

[tommycli, 2015-11-05 17:19:40]

tommycli@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[tommycli, 2015-11-05 17:19:40]

phajdan.jr: PTAL. Let me know if the SWPOwner changes look reasonable.

Thanks,

Tommy

[Paweł Hajdan Jr., 2015-11-06 15:08:49]

I'm fine with the public interface changes.

I don't feel comfortable reviewing the threading-related parts of this CL.

Consider adding people e.g. from git blame from the base/ files to the review,
and let me know if you need an OWNER stamp (you'll likely need one from
base/OWNERS anyway, and I'm not part of that).

[tommycli, 2015-11-09 19:31:17]

tommycli@chromium.org changed reviewers:
+ brettw@chromium.org

[tommycli, 2015-11-09 19:31:17]

brettw: PTAL. May I have a review of the SequencedWorkerPoolOwner stuff? Thanks!

[brettw, 2015-12-01 18:17:50]

lgtm

https://codereview.chromium.org/1417353006/diff/40001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc
(left):

https://codereview.chromium.org/1417353006/diff/40001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc:49:
ui_task_runner.get(),
I found the old formatting here much better. If clang-format did this and you
want to make that work, I'd change so it looks like this:
  nullptr,  // drive_task_runner

[tommycli, 2015-12-02 19:57:05]

brettw: thanks!

https://codereview.chromium.org/1417353006/diff/40001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc
(left):

https://codereview.chromium.org/1417353006/diff/40001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc:49:
ui_task_runner.get(),
On 2015/12/01 at 18:17:50, brettw wrote:
> I found the old formatting here much better. If clang-format did this and you
want to make that work, I'd change so it looks like this:
>   nullptr,  // drive_task_runner

Done. See if this patchset looks better. It's also generated by git cl format.

[brettw, 2015-12-02 20:09:46]

lgtm

[tommycli, 2015-12-02 21:07:37]

brettw: Thanks!

[tommycli, 2015-12-02 21:07:41]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2015-12-02 21:08:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417353006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417353006/60001

[commit-bot: I haz the power, 2015-12-02 22:11:37]

Description was changed from

==========
Tests: Simplify SequencedWorkerPoolOwner, call Shutdown on destructor.

Also ports remaining tests using raw SWPs to use SWPOwner.

BUG=450228
==========

to

==========
Tests: Simplify SequencedWorkerPoolOwner, call Shutdown on destructor.

Also ports remaining tests using raw SWPs to use SWPOwner.

BUG=450228
==========

[commit-bot: I haz the power, 2015-12-02 22:11:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-02 22:12:17]

Description was changed from

==========
Tests: Simplify SequencedWorkerPoolOwner, call Shutdown on destructor.

Also ports remaining tests using raw SWPs to use SWPOwner.

BUG=450228
==========

to

==========
Tests: Simplify SequencedWorkerPoolOwner, call Shutdown on destructor.

Also ports remaining tests using raw SWPs to use SWPOwner.

BUG=450228

Committed: https://crrev.com/fc939726c283e34112d9bc845a39460410fe9cd9
Cr-Commit-Position: refs/heads/master@{#362805}
==========

[commit-bot: I haz the power, 2015-12-02 22:12:18]

Patchset 4 (id:??) landed as
https://crrev.com/fc939726c283e34112d9bc845a39460410fe9cd9
Cr-Commit-Position: refs/heads/master@{#362805}

[tapted, 2015-12-03 03:37:13]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1496493004/ by tapted@chromium.org.

The reason for reverting is: Suspected for persistent failures on
ios_net_unittests

- RoundTripTestCookieStore/CookieStoreTest/0.TestNonDottedAndTLD
- CookieStoreIOS/CookieStoreTest/0.TestNonDottedAndTLD

Failing since
https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/bu...

Errors like 

../../net/cookies/cookie_store_unittest.h:536: Failure
Value of: this->SetCookie(cs.get(), url, "a=1; domain=com")
  Actual: false
Expected: true

(It's a tricky one! Sorry if this is not it).

[tapted, 2015-12-03 04:42:13]

relanded in https://codereview.chromium.org/1500503002/

(bot didn't recover in
https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/bu...
)