Tests: Simplify SequencedWorkerPoolOwner, call Shutdown on destructor.

chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync_file_system/drive_backend/sync_engine.h"
 
 #include "base/files/scoped_temp_dir.h"
 #include "base/macros.h"
 #include "base/run_loop.h"
+#include "base/test/sequenced_worker_pool_owner.h"
 #include "base/thread_task_runner_handle.h"
 #include "chrome/browser/sync_file_system/drive_backend/callback_helper.h"
 #include "chrome/browser/sync_file_system/drive_backend/fake_sync_worker.h"
 #include "chrome/browser/sync_file_system/drive_backend/sync_worker_interface.h"
 #include "chrome/browser/sync_file_system/remote_file_sync_service.h"
 #include "chrome/browser/sync_file_system/sync_file_system_test_util.h"
 #include "components/drive/drive_uploader.h"
 #include "components/drive/service/fake_drive_service.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace sync_file_system {
 namespace drive_backend {
 
 class SyncEngineTest : public testing::Test,
                        public base::SupportsWeakPtr<SyncEngineTest> {
  public:
   typedef RemoteFileSyncService::OriginStatusMap RemoteOriginStatusMap;
 
-  SyncEngineTest() {}
+  SyncEngineTest() : worker_pool_owner_(1, "Worker") {}
   ~SyncEngineTest() override {}
 
   void SetUp() override {
     ASSERT_TRUE(profile_dir_.CreateUniqueTempDir());
 
     scoped_ptr<drive::DriveServiceInterface>
         fake_drive_service(new drive::FakeDriveService);
 
-    worker_pool_ = new base::SequencedWorkerPool(1, "Worker");
     scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner =
         base::ThreadTaskRunnerHandle::Get();
     worker_task_runner_ =
-        worker_pool_->GetSequencedTaskRunnerWithShutdownBehavior(
-            worker_pool_->GetSequenceToken(),
+        worker_pool_owner_.pool()->GetSequencedTaskRunnerWithShutdownBehavior(
+            worker_pool_owner_.pool()->GetSequenceToken(),
             base::SequencedWorkerPool::SKIP_ON_SHUTDOWN);
 
     sync_engine_.reset(new drive_backend::SyncEngine(
-        ui_task_runner.get(),

[brettw, 2015/12/01 18:17:50]

I found the old formatting here much better. If clang-format did this and you
want to make that work, I'd change so it looks like this:
  nullptr,  // drive_task_runner

[tommycli, 2015/12/02 19:57:04]

Done. See if this patchset looks better. It's also generated by git cl format.

-        worker_task_runner_.get(),
-        nullptr /* drive_task_runner */,
-        worker_pool_.get(),
-        profile_dir_.path(),
-        nullptr /* task_logger */,
-        nullptr /* notification_manager */,
-        nullptr /* extension_service */,
-        nullptr /* signin_manager */,
-        nullptr /* token_service */,
-        nullptr /* request_context */,
-        nullptr /* drive_service_factory */,
+        ui_task_runner.get(), worker_task_runner_.get(),
+        nullptr /* drive_task_runner */, worker_pool_owner_.pool().get(),
+        profile_dir_.path(), nullptr /* task_logger */,
+        nullptr /* notification_manager */, nullptr /* extension_service */,
+        nullptr /* signin_manager */, nullptr /* token_service */,
+        nullptr /* request_context */, nullptr /* drive_service_factory */,
         nullptr /* in_memory_env */));
 
     sync_engine_->InitializeForTesting(
         fake_drive_service.Pass(),
         nullptr,  // drive_uploader
         scoped_ptr<SyncWorkerInterface>(new FakeSyncWorker));
     sync_engine_->SetSyncEnabled(true);
     sync_engine_->OnReadyToSendRequests();
 
     WaitForWorkerTaskRunner();
   }
 
   void TearDown() override {
     sync_engine_.reset();
     WaitForWorkerTaskRunner();
-    worker_pool_->Shutdown();
 
     worker_task_runner_ = nullptr;
-    worker_pool_ = nullptr;
-
-    base::RunLoop().RunUntilIdle();
   }
 
   bool FindOriginStatus(const GURL& origin, std::string* status) {
     scoped_ptr<RemoteOriginStatusMap> status_map;
     sync_engine()->GetOriginStatusMap(CreateResultReceiver(&status_map));
     WaitForWorkerTaskRunner();
 
     RemoteOriginStatusMap::const_iterator itr = status_map->find(origin);
     if (itr == status_map->end())
       return false;
@@ skipping 32 matching lines @@
 
   FakeSyncWorker* fake_sync_worker() {
     return static_cast<FakeSyncWorker*>(sync_engine_->sync_worker_.get());
   }
 
  private:
   content::TestBrowserThreadBundle browser_threads_;
   base::ScopedTempDir profile_dir_;
   scoped_ptr<drive_backend::SyncEngine> sync_engine_;
 
-  scoped_refptr<base::SequencedWorkerPool> worker_pool_;
+  base::SequencedWorkerPoolOwner worker_pool_owner_;
   scoped_refptr<base::SequencedTaskRunner> worker_task_runner_;
 
   DISALLOW_COPY_AND_ASSIGN(SyncEngineTest);
 };
 
 TEST_F(SyncEngineTest, OriginTest) {
   GURL origin("chrome-extension://app_0");
 
   SyncStatusCode sync_status;
   std::string status;
@@ skipping 85 matching lines @@
 TEST_F(SyncEngineTest, ProcessRemoteChange) {
   SyncStatusCode sync_status;
   storage::FileSystemURL url;
   sync_engine()->ProcessRemoteChange(CreateResultReceiver(&sync_status, &url));
   WaitForWorkerTaskRunner();
   EXPECT_EQ(SYNC_STATUS_OK, sync_status);
 }
 
 }  // namespace drive_backend
 }  // namespace sync_file_system