Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 141733005: Revert "Add gyp build of sel_ldr and irt_core for ARM." (Closed)

Created:
6 years, 11 months ago by Sam Clegg
Modified:
6 years, 11 months ago
CC:
native-client-reviews_googlegroups.com, Mark Seaborn
Visibility:
Public.

Description

Revert "Add gyp build of sel_ldr and irt_core for ARM." This reverts commit r12589 since it introduces a dependency on the linux ARM cross compiler when to to gyp build and this is not yet installed on the chromium trybots. This change should be re-applied once this compiler is installed: http://crbug.com/335303 > Add gyp build of sel_ldr and irt_core for ARM. > > The irt core can be built on all platforms but sel_ldr > can only be built on linux (the only platform with an > arm cross compiler). > > BUG=266959 > R=jvoung@chromium.org > > Review URL: https://codereview.chromium.org/93513013 BUG=266959 R=jvoung@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=12639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M build/nacl_core_sdk.gyp View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sam Clegg
6 years, 11 months ago (2014-01-18 00:36:22 UTC) #1
jvoung (off chromium)
lgtm
6 years, 11 months ago (2014-01-18 00:53:13 UTC) #2
Sam Clegg
6 years, 11 months ago (2014-01-18 01:56:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r12639 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698