Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 93513013: Add gyp build of sel_ldr and irt_core for ARM (Closed)

Created:
6 years, 11 months ago by Sam Clegg
Modified:
6 years, 11 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Add gyp build of sel_ldr and irt_core for ARM. The irt core can be built on all platforms but sel_ldr can only be built on linux (the only platform with an arm cross compiler). BUG=266959 R=jvoung@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=12589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M build/nacl_core_sdk.gyp View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sam Clegg
6 years, 11 months ago (2014-01-07 18:49:48 UTC) #1
jvoung (off chromium)
lgtm
6 years, 11 months ago (2014-01-07 19:27:00 UTC) #2
Sam Clegg
6 years, 11 months ago (2014-01-08 18:38:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r12589 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698