Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: content/browser/download/mhtml_generation_manager.h

Issue 1417323006: OOPIFs: Deduplicating MHTML parts across frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mhtml-serialization-per-frame
Patch Set: Rebasing... Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/mhtml_generation_manager.h
diff --git a/content/browser/download/mhtml_generation_manager.h b/content/browser/download/mhtml_generation_manager.h
index a05bb17da2a67ac8a11b0ee7757aafc52c235d03..cafaccb09894e53f631110d64190fcbd06bca036 100644
--- a/content/browser/download/mhtml_generation_manager.h
+++ b/content/browser/download/mhtml_generation_manager.h
@@ -6,6 +6,7 @@
#define CONTENT_BROWSER_DOWNLOAD_MHTML_GENERATION_MANAGER_H_
#include <map>
+#include <set>
#include <string>
#include "base/files/file.h"
@@ -13,6 +14,8 @@
#include "base/process/process.h"
#include "ipc/ipc_platform_file.h"
+class GURL;
ncarter (slow) 2015/12/04 21:52:39 You can't use forward declaration here; std::set<F
Łukasz Anforowicz 2015/12/04 22:55:43 I thought that this is ok, because I don't need a
+
namespace base {
class FilePath;
}
@@ -42,7 +45,8 @@ class MHTMLGenerationManager {
// that the MHTML generation finished).
void OnSavedPageAsMHTML(int job_id,
bool mhtml_generation_in_renderer_succeeded,
- const std::string& mhtml_boundary_marker);
+ const std::string& mhtml_boundary_marker,
+ const std::set<GURL>& uris_of_generated_mhtml_parts);
private:
friend struct base::DefaultSingletonTraits<MHTMLGenerationManager>;

Powered by Google App Engine
This is Rietveld 408576698