OOPIFs: Deduplicating MHTML parts across frames.

content/browser/download/mhtml_generation_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DOWNLOAD_MHTML_GENERATION_MANAGER_H_
 #define CONTENT_BROWSER_DOWNLOAD_MHTML_GENERATION_MANAGER_H_
 
 #include <map>
+#include <set>
 #include <string>
 
 #include "base/files/file.h"
 #include "base/memory/singleton.h"
 #include "base/process/process.h"
 #include "ipc/ipc_platform_file.h"
 
+class GURL;

[ncarter (slow), 2015/12/04 21:52:39]

You can't use forward declaration here; std::set<Foo> requires a definition for
Foo.

[Łukasz Anforowicz, 2015/12/04 22:55:43]

I thought that this is ok, because I don't need a std::set<GURL> *value* - I
just need a reference.  OTOH, to name the type of the reference, I need to tell
the compiler that GURL is a valid typename.  Still - I am not very confident in
my reasoning above / I shouldn't ask readers to jump through mental hoops to see
what is ok and what isn't.  So, let me just add the include.

+
 namespace base {
 class FilePath;
 }
 
 namespace content {
 
 class WebContents;
 
 // The class and all of its members live on the UI thread.  Only static methods
 // are executed on other threads.
 class MHTMLGenerationManager {
  public:
   static MHTMLGenerationManager* GetInstance();
 
   // GenerateMHTMLCallback is called to report completion and status of MHTML
   // generation.  On success |file_size| indicates the size of the
   // generated file.  On failure |file_size| is -1.
   typedef base::Callback<void(int64 file_size)> GenerateMHTMLCallback;
 
   // Instructs the render view to generate a MHTML representation of the current
   // page for |web_contents|.
   void SaveMHTML(WebContents* web_contents,
                  const base::FilePath& file_path,
                  const GenerateMHTMLCallback& callback);
 
   // Handler for ViewHostMsg_SavedPageAsMHTML (a notification from the renderer
   // that the MHTML generation finished).
   void OnSavedPageAsMHTML(int job_id,
                           bool mhtml_generation_in_renderer_succeeded,
-                          const std::string& mhtml_boundary_marker);
+                          const std::string& mhtml_boundary_marker,
+                          const std::set<GURL>& uris_of_generated_mhtml_parts);
 
  private:
   friend struct base::DefaultSingletonTraits<MHTMLGenerationManager>;
   class Job;
   enum class JobStatus { SUCCESS, FAILURE };
 
   MHTMLGenerationManager();
   virtual ~MHTMLGenerationManager();
 
   // Called on the file thread to create |file|.
@@ skipping 22 matching lines @@
   IDToJobMap id_to_job_;
 
   int next_job_id_;
 
   DISALLOW_COPY_AND_ASSIGN(MHTMLGenerationManager);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_MHTML_GENERATION_MANAGER_H_