content/browser/frame_host/render_frame_host_impl.h - Issue 1417323006: OOPIFs: Deduplicating MHTML parts across frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1417323006: OOPIFs: Deduplicating MHTML parts across frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mhtml-serialization-per-frame

Patch Set: Addressed CR feedback from rdsmith@. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/mhtml_generation_manager.cc ('K') | « content/browser/download/mhtml_generation_manager.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.h

diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h

index d6bafa37851a17a1bf3b6e6f8eb54d9e324d5893..b188616c757734f13d1b53fdb2177d63ae1944b8 100644

--- a/content/browser/frame_host/render_frame_host_impl.h

+++ b/content/browser/frame_host/render_frame_host_impl.h

@@ -6,6 +6,7 @@

#define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_

#include <map>

+#include <set>

#include <string>

#include <vector>

@@ -615,7 +616,10 @@ class CONTENT_EXPORT RenderFrameHostImpl

void OnDidStartLoading(bool to_different_document);

void OnDidStopLoading();

void OnDidChangeLoadProgress(double load_progress);

- void OnSerializeAsMHTMLResponse(int job_id, bool success);

+ void OnSerializeAsMHTMLResponse(

+ int job_id,

+ bool success,

+ const std::set<std::string>& digests_of_uris_of_serialized_resources);

#if defined(OS_MACOSX) || defined(OS_ANDROID)

void OnShowPopup(const FrameHostMsg_ShowPopup_Params& params);