content/browser/frame_host/render_frame_host_impl.cc - Issue 1417323006: OOPIFs: Deduplicating MHTML parts across frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1417323006: OOPIFs: Deduplicating MHTML parts across frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mhtml-serialization-per-frame

Patch Set: Addressed CR feedback from rdsmith@. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/mhtml_generation_manager.cc ('K') | « content/browser/frame_host/render_frame_host_impl.h ('k') | content/common/frame_messages.h » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index 25f1e1dd42678fc17438528ec72583c05ed071d1..d85c8fef82c207b953facef349283b1a8e89a515 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -1710,8 +1710,13 @@ void RenderFrameHostImpl::OnDidChangeLoadProgress(double load_progress) {

frame_tree_node_->DidChangeLoadProgress(load_progress);

}

-void RenderFrameHostImpl::OnSerializeAsMHTMLResponse(int job_id, bool success) {

- MHTMLGenerationManager::GetInstance()->OnSavedFrameAsMHTML(job_id, success);

+void RenderFrameHostImpl::OnSerializeAsMHTMLResponse(

+ int job_id,

+ bool success,

+ const std::set<std::string>& digests_of_uris_of_serialized_resources) {

+ MHTMLGenerationManager::GetInstance()->OnSerializeAsMHTMLResponse(

+ frame_tree_node()->frame_tree_node_id(), job_id, success,

+ digests_of_uris_of_serialized_resources);

}

#if defined(OS_MACOSX) || defined(OS_ANDROID)