Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1417323005: Rename Compiler.runCompiler -> runInternal. (Closed)

Created:
5 years, 1 month ago by sigurdm
Modified:
5 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename Compiler.runCompiler -> runInternal. Also renamed MockCompiler.runCompiler to MockCompiler.run Change all tests to use Compiler.run. BUG= R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/f10470741a9799fdde3a21d625438a52d5f433e9

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -84 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 2 chunks +6 lines, -2 lines 2 comments Download
M tests/compiler/dart2js/analyze_all_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/call_site_simple_type_inferer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/closure_tracer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/compile_with_empty_libraries_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/concrete_type_inference_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/field_type_simple_inferer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/gvn_dynamic_field_get_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/issue13354_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/js_spec_optimization_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/list_tracer2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/list_tracer3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/list_tracer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/map_tracer_const_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/map_tracer_keys_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/map_tracer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/metadata_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mirror_system_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/no_such_method_codegen_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/no_such_method_enabled_test.dart View 12 chunks +12 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/private_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/resolution_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/serialization_analysis_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_and_or_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_callers_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_closure_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_const_closure2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_const_closure3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_const_closure4_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_const_closure5_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_const_closure_default_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_const_closure_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_final_field2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_final_field3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_final_field_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_global_field_closure2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_global_field_closure_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_postfix_prefix_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_try_catch_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_unregister_call_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/source_mapping_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/trust_type_annotations_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_equals_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_inference6_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_inference7_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_inference8_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_mask_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_variable_bound_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/union_type_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/try/poi/compiler_test_case.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
sigurdm
5 years, 1 month ago (2015-10-29 09:27:56 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/1417323005/diff/20001/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/1417323005/diff/20001/pkg/compiler/lib/src/compiler.dart#newcode548 pkg/compiler/lib/src/compiler.dart:548: // succeded. Thanks!
5 years, 1 month ago (2015-10-29 10:48:32 UTC) #5
sigurdm
Committed patchset #1 (id:20001) manually as f10470741a9799fdde3a21d625438a52d5f433e9 (presubmit successful).
5 years, 1 month ago (2015-10-29 12:30:40 UTC) #6
sigurdm
5 years, 1 month ago (2015-10-29 12:30:42 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1417323005/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/1417323005/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/compiler.dart:548: // succeded.
On 2015/10/29 10:48:32, Johnni Winther wrote:
> Thanks!

Acknowledged.

Powered by Google App Engine
This is Rietveld 408576698