Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: pkg/compiler/lib/src/compiler.dart

Issue 1417323005: Rename Compiler.runCompiler -> runInternal. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/compiler/dart2js/analyze_all_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/compiler.dart
diff --git a/pkg/compiler/lib/src/compiler.dart b/pkg/compiler/lib/src/compiler.dart
index cf9ca73809dc49c4bd8c795f93aaf0cde1d40897..d07dbd2ac867261244381717837b02e13e663d38 100644
--- a/pkg/compiler/lib/src/compiler.dart
+++ b/pkg/compiler/lib/src/compiler.dart
@@ -542,10 +542,14 @@ abstract class Compiler {
reporter.internalError(spannable, "$methodName not implemented.");
}
+ // Compiles the dart script at [uri].
+ //
+ // The resulting future will complete with true if the compilation
+ // succeded.
Johnni Winther 2015/10/29 10:48:32 Thanks!
sigurdm 2015/10/29 12:30:42 Acknowledged.
Future<bool> run(Uri uri) {
totalCompileTime.start();
- return new Future.sync(() => runCompiler(uri))
+ return new Future.sync(() => runInternal(uri))
.catchError((error) => _reporter.onError(uri, error))
.whenComplete(() {
tracer.close();
@@ -828,7 +832,7 @@ abstract class Compiler {
*/
Uri resolvePatchUri(String dartLibraryPath);
- Future runCompiler(Uri uri) {
+ Future runInternal(Uri uri) {
// TODO(ahe): This prevents memory leaks when invoking the compiler
// multiple times. Implement a better mechanism where we can store
// such caches in the compiler and get access to them through a
« no previous file with comments | « no previous file | tests/compiler/dart2js/analyze_all_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698