Remove Collection, Collections and clean up List/Set/Queue implementations of retain/remove.

pkg/analyzer_experimental/lib/src/generated/element.dart

Index: pkg/analyzer_experimental/lib/src/generated/element.dart
diff --git a/pkg/analyzer_experimental/lib/src/generated/element.dart b/pkg/analyzer_experimental/lib/src/generated/element.dart
index 1a140b963be8f086e6f3ce95b41776c31b925458..7379d7b3a1fbd822d3c1c83f783cbf754a626133 100644
--- a/pkg/analyzer_experimental/lib/src/generated/element.dart
+++ b/pkg/analyzer_experimental/lib/src/generated/element.dart
@@ -1277,7 +1277,7 @@ class ClassElementImpl extends ElementImpl implements ClassElement {
   accept(ElementVisitor visitor) => visitor.visitClassElement(this);
   List<PropertyAccessorElement> get accessors => _accessors;
   List<InterfaceType> get allSupertypes {
-    Collection<InterfaceType> list = new Set<InterfaceType>();
+    Iterable<InterfaceType> list = new Set<InterfaceType>();

[floitsch, 2013/04/11 15:17:50]

Set and the name should be replaced from 'list' to 'set' :)

[Anders Johnsen, 2013/04/12 09:31:14]

Done.

     collectAllSupertypes(list);
     return new List.from(list);
   }
@@ -1541,7 +1541,7 @@ class ClassElementImpl extends ElementImpl implements ClassElement {
       builder.append(">");
     }
   }
-  void collectAllSupertypes(Collection<InterfaceType> list) {
+  void collectAllSupertypes(Iterable<InterfaceType> list) {

[floitsch, 2013/04/11 15:17:50]

No. There is an 'add' call in line 1548.
Make it 'var'.

[Anders Johnsen, 2013/04/12 09:31:14]

Done.

     if (_supertype == null || list.contains(_supertype)) {
       return;
     }
@@ -4913,4 +4913,4 @@ abstract class TypeVariableType implements Type2 {
  */
 abstract class VoidType implements Type2 {
   VoidType substitute2(List<Type2> argumentTypes, List<Type2> parameterTypes);
-}
+}