Issue 1417263002: Revert of Dependencies are now added between the drawTargets in GrPipeline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1417263002: Revert of Dependencies are now added between the drawTargets in GrPipeline (Closed)

Created:
5 years, 2 months ago by robertphillips

Modified:
5 years, 2 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@mdb-adddeps

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Dependencies are now added between the drawTargets in GrPipeline (patchset #6 id:120001 of https://codereview.chromium.org/1414903002/ ) Reason for revert: Breaking bots Original issue's description: > Dependencies are now added between the drawTargets in GrPipeline > > This CL relies on https://codereview.chromium.org/1414773002/ (Add the machinery to GrDrawTarget to enable topological sorting) > > BUG=skia:4094 > > Committed: https://skia.googlesource.com/skia/+/45a1c34f607a970933e5cd05e1df6cd8090db1be > > Committed: https://skia.googlesource.com/skia/+/869c5e82a725a6928a45cd1fa6945ac783b8b3d8 TBR=bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4094 Committed: https://skia.googlesource.com/skia/+/a352b14c8796c0d01ea8581c157a52c7d00973f5

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -75 lines)			Patch
M	include/gpu/GrRenderTarget.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/gpu/GrDrawTarget.h	View	4 chunks	+1 line, -8 lines	0 comments	Download
M	src/gpu/GrDrawTarget.cpp	View	5 chunks	+3 lines, -17 lines	0 comments	Download
M	src/gpu/GrDrawingManager.cpp	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	src/gpu/GrPipeline.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/gpu/GrPipeline.cpp	View	2 chunks	+0 lines, -30 lines	0 comments	Download
M	src/gpu/GrRenderTarget.cpp	View	2 chunks	+3 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

robertphillips

Created Revert of Dependencies are now added between the drawTargets in GrPipeline

5 years, 2 months ago (2015-10-22 12:31:19 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417263002/1

5 years, 2 months ago (2015-10-22 12:31:29 UTC) #2

commit-bot: I haz the power

5 years, 2 months ago (2015-10-22 12:31:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a352b14c8796c0d01ea8581c157a52c7d00973f5

Expand Messages | Collapse Messages