Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: hunspell.gyp

Issue 14172021: Guard gcc_version in a safe condition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/hunspell/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: hunspell.gyp
===================================================================
--- hunspell.gyp (revision 196550)
+++ hunspell.gyp (working copy)
@@ -73,13 +73,15 @@
'-Wno-write-strings',
],
}],
- ['gcc_version >= 48', {
- 'cflags': [
- # affentry.hxx has NULL as default parameter for a FLAG in two
- # places.
- '-Wno-conversion-null',
- ],
- }],
+ ['os_posix==1 and OS!="mac" and OS!="ios"',
Nico 2013/04/26 00:35:56 This now needs another 'conditions' child, right?
tfarina 2013/04/26 00:48:07 Done.
+ ['gcc_version >= 48', {
+ 'cflags': [
+ # affentry.hxx has NULL as default parameter for a FLAG in two
+ # places.
+ '-Wno-conversion-null',
+ ],
+ }],
+ ],
['clang == 1', {
'xcode_settings': {
'WARNING_CFLAGS': [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698