Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: hunspell.gyp

Issue 14172021: Guard gcc_version in a safe condition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/hunspell/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 'target_name': 'hunspell', 8 'target_name': 'hunspell',
9 'type': 'static_library', 9 'type': 'static_library',
10 'msvs_guid': 'D5E8DCB2-9C61-446F-8BEE-B18CA0E0936E', 10 'msvs_guid': 'D5E8DCB2-9C61-446F-8BEE-B18CA0E0936E',
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 # TODO(jschuh): http://crbug.com/167187 size_t -> int 66 # TODO(jschuh): http://crbug.com/167187 size_t -> int
67 'msvs_disabled_warnings': [ 4267 ], 67 'msvs_disabled_warnings': [ 4267 ],
68 'conditions': [ 68 'conditions': [
69 ['os_posix == 1 and OS != "mac"', { 69 ['os_posix == 1 and OS != "mac"', {
70 'cflags': [ 70 'cflags': [
71 '-Wno-unused-value', 71 '-Wno-unused-value',
72 '-Wno-unused-variable', 72 '-Wno-unused-variable',
73 '-Wno-write-strings', 73 '-Wno-write-strings',
74 ], 74 ],
75 }], 75 }],
76 ['gcc_version >= 48', { 76 ['os_posix==1 and OS!="mac" and OS!="ios"',
Nico 2013/04/26 00:35:56 This now needs another 'conditions' child, right?
tfarina 2013/04/26 00:48:07 Done.
77 'cflags': [ 77 ['gcc_version >= 48', {
78 # affentry.hxx has NULL as default parameter for a FLAG in two 78 'cflags': [
79 # places. 79 # affentry.hxx has NULL as default parameter for a FLAG in two
80 '-Wno-conversion-null', 80 # places.
81 ], 81 '-Wno-conversion-null',
82 }], 82 ],
83 }],
84 ],
83 ['clang == 1', { 85 ['clang == 1', {
84 'xcode_settings': { 86 'xcode_settings': {
85 'WARNING_CFLAGS': [ 87 'WARNING_CFLAGS': [
86 # affentry.cxx has one `while ((p = nextchar(p)));` parsing loop. 88 # affentry.cxx has one `while ((p = nextchar(p)));` parsing loop.
87 '-Wno-empty-body', 89 '-Wno-empty-body',
88 # affentry.hxx has NULL as default parameter for a FLAG in two 90 # affentry.hxx has NULL as default parameter for a FLAG in two
89 # places. 91 # places.
90 '-Wno-null-conversion', 92 '-Wno-null-conversion',
91 ], 93 ],
92 }, 94 },
93 'cflags': [ 95 'cflags': [
94 '-Wno-empty-body', 96 '-Wno-empty-body',
95 '-Wno-null-conversion', 97 '-Wno-null-conversion',
96 ], 98 ],
97 }], 99 }],
98 ], 100 ],
99 }, 101 },
100 ], 102 ],
101 } 103 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698