Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1658)

Issue 14172021: Guard gcc_version in a safe condition. (Closed)

Created:
7 years, 8 months ago by tfarina
Modified:
7 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Guard gcc_version in a safe condition. gcc_version is only defined on Linux and thus we need to check for it before using it on other platforms. This should fix the following error: gyp: name 'gcc_version' is not defined while evaluating condition 'gcc_version >= 48' R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196565

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : fix indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M hunspell.gyp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
https://codereview.chromium.org/14172021/diff/1/hunspell.gyp File hunspell.gyp (right): https://codereview.chromium.org/14172021/diff/1/hunspell.gyp#newcode76 hunspell.gyp:76: ['os_posix==1 and OS!="mac" and OS!="ios"', This now needs another ...
7 years, 8 months ago (2013-04-26 00:35:56 UTC) #1
tfarina
https://codereview.chromium.org/14172021/diff/1/hunspell.gyp File hunspell.gyp (right): https://codereview.chromium.org/14172021/diff/1/hunspell.gyp#newcode76 hunspell.gyp:76: ['os_posix==1 and OS!="mac" and OS!="ios"', On 2013/04/26 00:35:56, Nico ...
7 years, 8 months ago (2013-04-26 00:48:07 UTC) #2
Nico
lgtm https://codereview.chromium.org/14172021/diff/6001/hunspell.gyp File hunspell.gyp (right): https://codereview.chromium.org/14172021/diff/6001/hunspell.gyp#newcode77 hunspell.gyp:77: 'cflags': [ The old indent was right, I ...
7 years, 8 months ago (2013-04-26 00:58:07 UTC) #3
tfarina
landing. Thanks for the review! https://codereview.chromium.org/14172021/diff/6001/hunspell.gyp File hunspell.gyp (right): https://codereview.chromium.org/14172021/diff/6001/hunspell.gyp#newcode77 hunspell.gyp:77: 'cflags': [ On 2013/04/26 ...
7 years, 8 months ago (2013-04-26 01:02:27 UTC) #4
tfarina
7 years, 8 months ago (2013-04-26 01:03:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r196565 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698