Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1417173008: Move MotionEventAndroid to ui/events/android (Closed)

Created:
5 years, 1 month ago by Khushal
Modified:
5 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, Fady Samuel, jam, tdresser+watch_chromium.org, Wez
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move MotionEventAndroid to ui/events/android BUG=550531 Committed: https://crrev.com/2ae6c8360dfbc0638cff325f4c9f631893c04a32 Cr-Commit-Position: refs/heads/master@{#358131}

Patch Set 1 #

Patch Set 2 : Add OWNERS for ui/events/android #

Total comments: 4

Patch Set 3 : Copyright date fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -765 lines) Patch
M build/jar_file_jni_generator.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M content/app/android/library_loader_hooks.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 5 chunks +4 lines, -4 lines 0 comments Download
D content/browser/renderer_host/input/motion_event_android.h View 1 1 chunk +0 lines, -138 lines 0 comments Download
D content/browser/renderer_host/input/motion_event_android.cc View 1 1 chunk +0 lines, -362 lines 0 comments Download
D content/browser/renderer_host/input/motion_event_android_unittest.cc View 1 1 chunk +0 lines, -224 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_builders_android.h View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_builders_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content.gyp View 1 1 chunk +0 lines, -10 lines 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/content_test_suite_base.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/events/BUILD.gn View 3 chunks +25 lines, -0 lines 0 comments Download
A + ui/events/android/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/events/android/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
A ui/events/android/events_jni_registrar.h View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A + ui/events/android/events_jni_registrar.cc View 1 2 1 chunk +9 lines, -8 lines 0 comments Download
A + ui/events/android/motion_event_android.h View 1 2 chunks +7 lines, -6 lines 0 comments Download
A + ui/events/android/motion_event_android.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + ui/events/android/motion_event_android_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/events/events.gyp View 3 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (7 generated)
Khushal
5 years, 1 month ago (2015-11-03 18:18:17 UTC) #3
David Trainor- moved to gerrit
lgtm!
5 years, 1 month ago (2015-11-03 19:31:23 UTC) #4
agrieve
On 2015/11/03 19:31:23, David Trainor wrote: > lgtm! build/ lgtm
5 years, 1 month ago (2015-11-03 20:24:29 UTC) #7
tdresser
On 2015/11/03 20:24:29, agrieve wrote: > On 2015/11/03 19:31:23, David Trainor wrote: > > lgtm! ...
5 years, 1 month ago (2015-11-04 13:06:37 UTC) #8
sadrul
On 2015/11/04 13:06:37, tdresser wrote: > On 2015/11/03 20:24:29, agrieve wrote: > > On 2015/11/03 ...
5 years, 1 month ago (2015-11-04 14:50:00 UTC) #9
Khushal
On 2015/11/04 14:50:00, sadrul wrote: > On 2015/11/04 13:06:37, tdresser wrote: > > On 2015/11/03 ...
5 years, 1 month ago (2015-11-04 17:49:31 UTC) #10
Khushal
On 2015/11/04 17:49:31, Khushal wrote: > On 2015/11/04 14:50:00, sadrul wrote: > > On 2015/11/04 ...
5 years, 1 month ago (2015-11-05 18:24:10 UTC) #12
tdresser
LGTM, with copyright date fixes. https://codereview.chromium.org/1417173008/diff/20001/ui/events/android/events_jni_registrar.cc File ui/events/android/events_jni_registrar.cc (right): https://codereview.chromium.org/1417173008/diff/20001/ui/events/android/events_jni_registrar.cc#newcode1 ui/events/android/events_jni_registrar.cc:1: // Copyright 2014 The ...
5 years, 1 month ago (2015-11-05 18:52:40 UTC) #13
aelias_OOO_until_Jul13
lgtm
5 years, 1 month ago (2015-11-05 19:36:28 UTC) #14
piman
content/ LGTM
5 years, 1 month ago (2015-11-05 19:38:26 UTC) #15
sadrul
events stamp lgtm
5 years, 1 month ago (2015-11-05 19:43:32 UTC) #16
Khushal
Thanks! https://codereview.chromium.org/1417173008/diff/20001/ui/events/android/events_jni_registrar.cc File ui/events/android/events_jni_registrar.cc (right): https://codereview.chromium.org/1417173008/diff/20001/ui/events/android/events_jni_registrar.cc#newcode1 ui/events/android/events_jni_registrar.cc:1: // Copyright 2014 The Chromium Authors. All rights ...
5 years, 1 month ago (2015-11-05 20:13:04 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417173008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417173008/40001
5 years, 1 month ago (2015-11-05 20:13:51 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-05 21:22:12 UTC) #21
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 21:22:51 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2ae6c8360dfbc0638cff325f4c9f631893c04a32
Cr-Commit-Position: refs/heads/master@{#358131}

Powered by Google App Engine
This is Rietveld 408576698