Issue 1417113004: [Extensions] Migrate ServiceWorker off behavior feature system

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1417113004: [Extensions] Migrate ServiceWorker off behavior feature system (Closed)

Created:
5 years, 1 month ago by Devlin

Modified:
5 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2526

Target Ref:
refs/pending/branch-heads/2526

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Extensions] Migrate ServiceWorker off behavior feature system The FeatureSystem is failing to retrieve the behavior feature for service workers, but the only reason this seems to be the case is because of potential corruption in the JSON files (or the JSON parser otherwise choking). For now, to reduce the crash rates, just migrate the service worker restriction off the behavior feature system. BUG=461915 Review URL: https://codereview.chromium.org/1417563005 Cr-Commit-Position: refs/heads/master@{#356123} (cherry picked from commit 2507a2fcd25244dadb7dfcc316426bee7b1df275) Committed: https://chromium.googlesource.com/chromium/src/+/42e6d14c907e9592e34ca69d61d58db8ca1bf275

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -13 lines)			Patch
M	chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	extensions/renderer/dispatcher.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	extensions/renderer/dispatcher.cc	View	2 chunks	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Devlin

5 years, 1 month ago (2015-10-27 23:10:35 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
42e6d14c907e9592e34ca69d61d58db8ca1bf275.

Expand Messages | Collapse Messages