Revert of Call reset(nullptr) in scoped_ptr's.

Revert of Call reset(nullptr) in scoped_ptr's. (patchset #7 id:120001 of https://codereview.chromium.org/1356483002/ )

Reason for revert:
Sorry for reverting, I assume there is nothing really wrong with this cl but it breaks ToolbarControllerTest on Mac 10.10 and 10.11.
http://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/3607

Original issue's description:
> Call reset(nullptr) in scoped_ptr's destructor.
>
> This behaviour is consistent with libc++.
>
> The original goal of this change is to make Chrome crash more often
> and closer to the source when there's a use-after-free bug that
> accesses a destroyed scoped_ptr.
>
> BUG=535321
>
> Committed: https://crrev.com/cf9db6ef148d1493dbf6bdc6693f9c79e3ac2afc
> Cr-Commit-Position: refs/heads/master@{#357297}

TBR=danakj@chromium.org,pkasting@chromium.org,amistry@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=535321
Committed: https://crrev.com/0db76eefa32b0b4c29d4a01c1849ac2b2feecb15
Cr-Commit-Position: refs/heads/master@{#357335}

[perkj_chrome, 2015-11-02 11:50:05]

Created Revert of Call reset(nullptr) in scoped_ptr's.

[commit-bot: I haz the power, 2015-11-02 11:50:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417063006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417063006/1

[commit-bot: I haz the power, 2015-11-02 11:50:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-02 11:51:44]

Patchset 1 (id:??) landed as
https://crrev.com/0db76eefa32b0b4c29d4a01c1849ac2b2feecb15
Cr-Commit-Position: refs/heads/master@{#357335}

[Peter Kasting, 2015-11-02 19:07:25]

If this breaks that test, doesn't that mean the test is incorrect and should be
disabled until it's fixed, instead of reverting this?

[danakj, 2015-11-02 19:41:06]

On Mon, Nov 2, 2015 at 11:07 AM, <pkasting@chromium.org> wrote:

> If this breaks that test, doesn't that mean the test is incorrect and
> should be
> disabled until it's fixed, instead of reverting this?
>

It does, but there were a number of bugs that had to be fixed to land this,
I guess that one got missed. We can fix the test and then reland.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.