Ensure traces with bad timers are not taken into accound in the startup report.

Ensure traces with bad timers are not taken into accound in the startup report.

BUG=#1680

[beaudoin, 2015-10-28 23:22:21]

beaudoin@chromium.org changed reviewers:
+ nduca@chromium.org

[nduca, 2015-10-29 21:43:13]

https://codereview.chromium.org/1417063004/diff/1/perf_insights/perf_insights...
File perf_insights/perf_insights/mappers/slice_cost.html (right):

https://codereview.chromium.org/1417063004/diff/1/perf_insights/perf_insights...
perf_insights/perf_insights/mappers/slice_cost.html:171: // boundary we got a
trace with a poor timer, conditionally ignore it.
i think this patch should probably block on
https://github.com/catapult-project/catapult/issues/1694

you might be able to then create a feature in trace event importer that says
"when we dont find a metadata record for whether its highres or not, guess using
this heuristic and set the model field directly."

at that point, then this cl is just stopping generation of reports when its
lowres. which tbh might be an overall feature we want on the mapping engine
instead of being something that every mapper should do...

[beaudoin, 2015-10-30 14:09:53]

https://codereview.chromium.org/1417063004/diff/1/perf_insights/perf_insights...
File perf_insights/perf_insights/mappers/slice_cost.html (right):

https://codereview.chromium.org/1417063004/diff/1/perf_insights/perf_insights...
perf_insights/perf_insights/mappers/slice_cost.html:171: // boundary we got a
trace with a poor timer, conditionally ignore it.
On 2015/10/29 21:43:12, nduca wrote:
> i think this patch should probably block on
> https://github.com/catapult-project/catapult/issues/1694
> 
> you might be able to then create a feature in trace event importer that says
> "when we dont find a metadata record for whether its highres or not, guess
using
> this heuristic and set the model field directly."
> 
> at that point, then this cl is just stopping generation of reports when its
> lowres. which tbh might be an overall feature we want on the mapping engine
> instead of being something that every mapper should do...

Wasn't sure how early you wanted to trim these traces since in the meeting you
sounded like you though low-rez traces were still useful for other reports. I
totally support making it a feature of the mapper.

[nduca, 2015-11-06 18:51:24]

do we have line of sight to landing this?

[beaudoin, 2015-11-06 19:38:55]

On 2015/11/06 18:51:24, nduca wrote:
> do we have line of sight to landing this?

Will reactivate it taking your comments into account.

[nduca, 2015-11-07 22:00:39]

\o/

[beaudoin, 2015-11-19 02:59:07]

On 2015/11/07 22:00:39, nduca wrote:
> \o/

Closing, deprecated.