Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: perf_insights/perf_insights/mappers/startup_map_function.html

Issue 1417063004: Ensure traces with bad timers are not taken into accound in the startup report. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: perf_insights/perf_insights/mappers/startup_map_function.html
diff --git a/perf_insights/perf_insights/mappers/startup_map_function.html b/perf_insights/perf_insights/mappers/startup_map_function.html
index 84331d519edef73a6231f01b5a6de7e770ac5d21..6688633ab6c3bfbd02434686e6fed7b16ed5b22e 100644
--- a/perf_insights/perf_insights/mappers/startup_map_function.html
+++ b/perf_insights/perf_insights/mappers/startup_map_function.html
@@ -28,13 +28,17 @@ tr.exportTo('pi.m', function() {
threadGrouping.autoInitUsingHelpers(model);
// TODO(beaudoin): Use the Startup IR associated events to filter out what
// should be included there, once the associated events work correctly.
- var sliceCosts = pi.m.getSliceCostReport(model, threadGrouping, {},
+ var sliceCosts = pi.m.getSliceCostReport(model, threadGrouping, {}, true,
function(event) {
return startupIR.bounds(event);
});
- results.addValue(new pi.v.DictValue(runInfo, 'sr',
- {sliceCosts: sliceCosts,
- startupDuration: startupIR.duration}));
+ if (sliceCosts.length === 0) {
+ results.addValue(new pi.v.SkipValue(runInfo, 'skipped'));
+ } else {
+ results.addValue(new pi.v.DictValue(runInfo, 'sr',
+ {sliceCosts: sliceCosts,
+ startupDuration: startupIR.duration}));
+ }
}
pi.MapFunction.register(startupMapFunction);

Powered by Google App Engine
This is Rietveld 408576698