Disable test and remove the reference of enable_localhost_ice_candidate

Disable test and remove the reference of enable_localhost_ice_candidate and RTCIceServerArray

This is really just reverting couple CLs to some previous state as the hack of generating the loopback candidate is not needed anymore.

BUG=

Committed: https://crrev.com/66aeb2b7084850d09f3fccc7d7467b57e4da1882
Cr-Commit-Position: refs/heads/master@{#356389}

[guoweis_left_chromium, 2015-10-22 18:40:37]

guoweis@chromium.org changed reviewers:
+ tommi@chromium.org

[guoweis_left_chromium, 2015-10-22 18:40:38]

PTAL.

We don't need the hack of generating the loopback candidates. Removing the call
and disabling the test which requires this behavior for now.

[guoweis_left_chromium, 2015-10-22 19:04:45]

Patchset #1 (id:1) has been deleted

[guoweis_left_chromium, 2015-10-22 19:10:54]

Description was changed from

==========
Disable test and remove the reference of enable_localhost_ice_candidate

BUG=
==========

to

==========
Disable test and remove the reference of enable_localhost_ice_candidate and
RTCIceServerArray

BUG=
==========

[guoweis_left_chromium, 2015-10-22 19:11:14]

Description was changed from

==========
Disable test and remove the reference of enable_localhost_ice_candidate and
RTCIceServerArray

BUG=
==========

to

==========
Disable test and remove the reference of enable_localhost_ice_candidate and
RTCIceServerArray

This is really just reverting couple CLs to some previous state.

BUG=
==========

[guoweis_left_chromium, 2015-10-22 19:11:36]

guoweis@chromium.org changed reviewers:
+ tkent@chromium.org

[guoweis_left_chromium, 2015-10-22 19:11:36]

tkent@chromium.org: Please review changes in WebKits

[tkent, 2015-10-22 22:53:56]

rs lgtm

[guoweis_left_chromium, 2015-10-22 23:23:59]

Description was changed from

==========
Disable test and remove the reference of enable_localhost_ice_candidate and
RTCIceServerArray

This is really just reverting couple CLs to some previous state.

BUG=
==========

to

==========
Disable test and remove the reference of enable_localhost_ice_candidate and
RTCIceServerArray

This is really just reverting couple CLs to some previous state as the hack of
generating the loopback candidate is not needed anymore.

BUG=
==========

[tommi (sloooow) - chröme, 2015-10-23 16:00:23]

https://codereview.chromium.org/1417023003/diff/80001/content/browser/media/w...
File content/browser/media/webrtc_browsertest.cc (right):

https://codereview.chromium.org/1417023003/diff/80001/content/browser/media/w...
content/browser/media/webrtc_browsertest.cc:21:
DISABLED_WebRtcBrowserPermissionDeniedTest
nit: 4 spaces

https://codereview.chromium.org/1417023003/diff/80001/content/renderer/media/...
File content/renderer/media/rtc_peer_connection_handler.cc (right):

https://codereview.chromium.org/1417023003/diff/80001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:189: if
(blink_config.isNull() || !webrtc_config)
the webrtc_config wasn't allowed to be null before, right?  If so, I suggest we
continue to treat that as an invalid case and have a DCHECK(webrtc_config) at
the top of the function instead of the second check here.

https://codereview.chromium.org/1417023003/diff/80001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:191: for (size_t i = 0; i
< blink_config.numberOfServers(); ++i) {
nit: add an empty line above this one for readability.

[tommi (sloooow) - chröme, 2015-10-23 16:02:39]

oops, forgot. lgtm with the above nits

[tommi (sloooow) - chröme, 2015-10-23 16:09:50]

On 2015/10/23 16:02:39, tommi wrote:
> oops, forgot. lgtm with the above nits

lgtm for RTCPeerConnection.html and RTCPeerConnection-expected.txt changes too.

[guoweis_left_chromium, 2015-10-23 16:10:22]

The CQ bit was checked by guoweis@chromium.org

[guoweis_left_chromium, 2015-10-23 16:10:23]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1417023003/#ps100001
(title: "added missing files from previous change   address comments from
Tommi")

[commit-bot: I haz the power, 2015-10-23 16:11:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417023003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417023003/100001

[commit-bot: I haz the power, 2015-10-23 17:04:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 17:04:32]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[guoweis_left_chromium, 2015-10-23 17:05:59]

The CQ bit was checked by guoweis@chromium.org

[commit-bot: I haz the power, 2015-10-23 17:06:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417023003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417023003/100001

[commit-bot: I haz the power, 2015-10-23 18:07:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 18:07:20]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[guoweis_left_chromium, 2015-10-27 18:19:44]

Patchset #6 (id:120001) has been deleted

[guoweis_left_chromium, 2015-10-27 19:14:27]

The CQ bit was checked by guoweis@chromium.org

[guoweis_left_chromium, 2015-10-27 19:14:27]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/1417023003/#ps140001
(title: "fix test cases with certificates")

[commit-bot: I haz the power, 2015-10-27 19:15:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417023003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417023003/140001

[commit-bot: I haz the power, 2015-10-27 20:43:23]

Committed patchset #6 (id:140001)

[commit-bot: I haz the power, 2015-10-27 20:44:09]

Patchset 6 (id:??) landed as
https://crrev.com/66aeb2b7084850d09f3fccc7d7467b57e4da1882
Cr-Commit-Position: refs/heads/master@{#356389}