Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html

Issue 1417023003: Disable test and remove the reference of enable_localhost_ice_candidate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix test cases with certificates Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html
diff --git a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html
index f256f8576b462c794c23803ff73e3a29fe6285a2..46be96dd90743ae5fe624b7235e5aa0066e0e8b9 100644
--- a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html
+++ b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html
@@ -21,10 +21,8 @@ shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', cr
shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x'},{url:'stun:bar.com'}]}, null);");
shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]}, null);");
shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:['stun:foo.com', 'turn:foo.com']}]}, null);");
-shouldNotThrow("new webkitRTCPeerConnection({iceServers:undefined}, null);");
-shouldNotThrow("new webkitRTCPeerConnection({}, null);");
-shouldThrow("new webkitRTCPeerConnection({iceServers:null}, null);");
+shouldThrow("new webkitRTCPeerConnection({fooServers:[]}, null);");
shouldThrow("new webkitRTCPeerConnection({iceServers:true}, null);");
shouldThrow("new webkitRTCPeerConnection({iceServers:[1, 2, 3]}, null);");
shouldThrow("new webkitRTCPeerConnection({iceServers:[{}]}, null);");
@@ -62,10 +60,10 @@ shouldThrow("new webkitRTCPeerConnection(null, {valid_but_unsupported_1:1});");
shouldThrow("new webkitRTCPeerConnection(null, {valid_and_supported_2:1, mandatory:{valid_and_supported_1:1}});");
// Construct with certificates.
-shouldNotThrow("new webkitRTCPeerConnection({certificates:null}, null);");
-shouldNotThrow("new webkitRTCPeerConnection({certificates:[]}, null);");
-shouldThrow("new webkitRTCPeerConnection({certificates:[null]}, null);");
-shouldThrow("new webkitRTCPeerConnection({certificates:[1337]}, null);");
+shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], certificates:null}, null);");
+shouldNotThrow("new webkitRTCPeerConnection({iceServers:[], certificates:[]}, null);");
+shouldThrow("new webkitRTCPeerConnection({iceServers:[], certificates:[null]}, null);");
+shouldThrow("new webkitRTCPeerConnection({iceServers:[], certificates:[1337]}, null);");
// Global certificate variables so that the "should..." methods can evaluate them.
var certRSA = null;
var certECDSA = null;
@@ -74,7 +72,7 @@ function testCertificates1RSA()
webkitRTCPeerConnection.generateCertificate({ name: "RSASSA-PKCS1-v1_5", modulusLength: 2048, publicExponent: 65537 })
.then(function(certificate) {
certRSA = certificate;
- shouldNotThrow('new webkitRTCPeerConnection({certificates:[certRSA]}, null);');
+ shouldNotThrow('new webkitRTCPeerConnection({iceServers:[], certificates:[certRSA]}, null);');
testCertificates2ECDSA();
},
function() {
@@ -87,7 +85,7 @@ function testCertificates2ECDSA()
webkitRTCPeerConnection.generateCertificate({ name: "ECDSA", namedCurve: "P-256" })
.then(function(certificate) {
certECDSA = certificate;
- shouldNotThrow('new webkitRTCPeerConnection({certificates:[certECDSA]}, null);');
+ shouldNotThrow('new webkitRTCPeerConnection({iceServers:[], certificates:[certECDSA]}, null);');
finishJSTest();
},
function() {

Powered by Google App Engine
This is Rietveld 408576698