Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3126)

Unified Diff: chrome/test/base/tracing_browsertest.cc

Issue 1417003003: [tracing] Dump child processes' memory metrics in browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@web_cache2_base
Patch Set: primiano's comments Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/tracing_browsertest.cc
diff --git a/chrome/test/base/tracing_browsertest.cc b/chrome/test/base/tracing_browsertest.cc
index 1b953594314f8d2b8f431892bd20ecf82643bd95..edb7734c80d7eeb9fb95c43c66ff93337db0f875 100644
--- a/chrome/test/base/tracing_browsertest.cc
+++ b/chrome/test/base/tracing_browsertest.cc
@@ -61,12 +61,19 @@ class TracingBrowserTest : public InProcessBrowserTest {
MemoryDumpManager::kTraceCategory,
event_name, 10));
- GURL url2("chrome://credits/");
+ // Start new processes and stop a process while tracing is enabled.
Primiano Tucci (use gerrit) 2016/01/05 11:55:17 I think you have other leftover of rebase conflict
ssid 2016/01/06 20:26:33 Adding close tab to make sure renderer is recycled
+ GURL url2("chrome://credits");
ui_test_utils::NavigateToURLWithDisposition(
browser(), url2, NEW_FOREGROUND_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
ASSERT_NO_FATAL_FAILURE(ExecuteJavascriptOnCurrentTab());
+ GURL url3("chrome://settings");
+ ui_test_utils::NavigateToURLWithDisposition(
+ browser(), url3, CURRENT_TAB,
+ ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
+ ASSERT_NO_FATAL_FAILURE(ExecuteJavascriptOnCurrentTab());
+
EXPECT_TRUE(WaitForWatchEvent(no_timeout));
ASSERT_TRUE(EndTracing(&json_events));

Powered by Google App Engine
This is Rietveld 408576698