components/policy/core/common/schema_registry.cc - Issue 1417003003: [tracing] Dump child processes' memory metrics in browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/schema_registry.cc

Issue 1417003003: [tracing] Dump child processes' memory metrics in browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@web_cache2_base

Patch Set: primiano's comments Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/policy/core/common/schema_registry.cc

diff --git a/components/policy/core/common/schema_registry.cc b/components/policy/core/common/schema_registry.cc

index a0b41052ec8d8d38bb170007edb55a7a4ab484a0..3fb693fb8a1f419c2cd45243bb55cfa924d3d37d 100644

--- a/components/policy/core/common/schema_registry.cc

+++ b/components/policy/core/common/schema_registry.cc

@@ -55,7 +55,6 @@ void SchemaRegistry::UnregisterComponent(const PolicyNamespace& ns) {

schema_map_ = new SchemaMap(map);

Notify(false);

} else {

- NOTREACHED();

Primiano Tucci (use gerrit) 2016/01/05 11:55:17 same here (conflicts)

ssid 2016/01/06 20:26:33 Done.

}

« chrome/test/base/tracing_browsertest.cc ('K') | « components/components_tests.gyp ('k') | components/tracing.gyp » ('j') | components/tracing.gyp » ('J')