Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: components/tracing/child_memory_dump_manager_delegate_impl.cc

Issue 1417003003: [tracing] Dump child processes' memory metrics in browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@web_cache2_base
Patch Set: dNits. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/tracing/child_memory_dump_manager_delegate_impl.cc
diff --git a/components/tracing/child_memory_dump_manager_delegate_impl.cc b/components/tracing/child_memory_dump_manager_delegate_impl.cc
index fe5c952f6a9a91ecf83ce42e81e49b543eb42974..5cb3a74b2601e9eefd11bca0af708300ba2ce788 100644
--- a/components/tracing/child_memory_dump_manager_delegate_impl.cc
+++ b/components/tracing/child_memory_dump_manager_delegate_impl.cc
@@ -6,6 +6,7 @@
#include "base/single_thread_task_runner.h"
Primiano Tucci (use gerrit) 2015/11/17 10:44:12 include what you use: add explicit build_config.h
ssid 2015/11/17 13:55:06 Done.
#include "components/tracing/child_trace_message_filter.h"
+#include "components/tracing/process_metrics_memory_dump_manager.h"
namespace tracing {
@@ -49,6 +50,12 @@ void ChildMemoryDumpManagerDelegateImpl::SetChildTraceMessageFilter(
if (ctmf) {
base::trace_event::MemoryDumpManager::GetInstance()->Initialize(
this /* delegate */, false /* is_coordinator */);
+
+#if !defined(OS_LINUX)
+ // Do not register in linux due to sandbox.
Primiano Tucci (use gerrit) 2015/11/17 10:44:12 Make this more explicit and say: on Linux the brow
ssid 2015/11/17 13:55:06 Done.
+ tracing::ProcessMetricsMemoryDumpManager::GetInstance()->RegisterForProcess(
+ base::kNullProcessHandle);
+#endif
}
}

Powered by Google App Engine
This is Rietveld 408576698