base/trace_event/trace_event.gypi - Issue 1417003003: [tracing] Dump child processes' memory metrics in browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_event.gypi

Issue 1417003003: [tracing] Dump child processes' memory metrics in browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@web_cache2_base

Patch Set: dNits. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/trace_event/process_memory_totals_dump_provider_unittest.cc ('k') | components/components_tests.gyp » ('j') | components/tracing/child_memory_dump_manager_delegate_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/trace_event/trace_event.gypi

diff --git a/base/trace_event/trace_event.gypi b/base/trace_event/trace_event.gypi

index 47133116ec485100a2bed45771db337f8af0a1be..483e1cdf8e94ab63dc6df5da1ea56fcd58a66d08 100644

--- a/base/trace_event/trace_event.gypi

+++ b/base/trace_event/trace_event.gypi

@@ -30,11 +30,8 @@

'trace_event/process_memory_dump.h',

'trace_event/process_memory_maps.cc',

'trace_event/process_memory_maps.h',

- 'trace_event/process_memory_maps_dump_provider.h',

'trace_event/process_memory_totals.cc',

'trace_event/process_memory_totals.h',

- 'trace_event/process_memory_totals_dump_provider.cc',

- 'trace_event/process_memory_totals_dump_provider.h',

'trace_event/trace_buffer.cc',

'trace_event/trace_buffer.h',

'trace_event/trace_config.cc',

@@ -88,9 +85,6 @@

}],

['OS == "linux" or OS == "android"', {

- 'trace_event_sources': [

- 'trace_event/process_memory_maps_dump_provider.cc',

- ],

'trace_event_test_sources' : [

'trace_event/process_memory_maps_dump_provider_unittest.cc',

Primiano Tucci (use gerrit) 2015/11/17 10:44:12 what about this unittest?

ssid 2015/11/17 13:55:06 Done.