Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1416953006: [types] Use unified integral representation bits. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[types] Use unified integral representation bits. We don't need to distinguish between signed and unsigned integral representations in the big boy type system. It actually even hurts in some cases. The representation is only about the way the values are mapped to bits in memory/registers, but the interpretation of the bits is specified by the semantic dimension. R=jarin@chromium.org Committed: https://crrev.com/6471fbf72ce07b54f154d550724ac063862294c3 Cr-Commit-Position: refs/heads/master@{#31771}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -42 lines) Patch
M src/code-stubs.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/typer.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M src/interface-descriptors.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M src/type-cache.h View 1 chunk +7 lines, -6 lines 0 comments Download
M src/types.h View 1 chunk +9 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-04 07:43:37 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the patch we talked about offline. Please take a look. Thanks, Benedikt
5 years, 1 month ago (2015-11-04 07:48:17 UTC) #3
Jarin
lgtm
5 years, 1 month ago (2015-11-04 08:00:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416953006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416953006/1
5 years, 1 month ago (2015-11-04 08:04:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 08:05:42 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 08:06:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6471fbf72ce07b54f154d550724ac063862294c3
Cr-Commit-Position: refs/heads/master@{#31771}

Powered by Google App Engine
This is Rietveld 408576698