Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: src/interface-descriptors.cc

Issue 1416953006: [types] Use unified integral representation bits. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | src/type-cache.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interface-descriptors.cc
diff --git a/src/interface-descriptors.cc b/src/interface-descriptors.cc
index 1af3cec41825fdbf9ec5c1f093cc0928f10a6ff3..297722c25576fd825c60537bedb34a0c579e7404 100644
--- a/src/interface-descriptors.cc
+++ b/src/interface-descriptors.cc
@@ -14,8 +14,8 @@ Type* SmiType(Zone* zone) {
}
-Type* UntaggedSigned32(Zone* zone) {
- return Type::Intersect(Type::Signed32(), Type::UntaggedSigned32(), zone);
+Type* UntaggedIntegral32(Zone* zone) {
+ return Type::Intersect(Type::Signed32(), Type::UntaggedIntegral32(), zone);
}
@@ -150,7 +150,7 @@ LoadGlobalViaContextDescriptor::BuildCallInterfaceDescriptorFunctionType(
Zone* zone = isolate->interface_descriptor_zone();
Type::FunctionType* function =
Type::FunctionType::New(AnyTagged(zone), Type::Undefined(), 1, zone);
- function->InitParameter(0, UntaggedSigned32(zone));
+ function->InitParameter(0, UntaggedIntegral32(zone));
return function;
}
@@ -168,7 +168,7 @@ StoreGlobalViaContextDescriptor::BuildCallInterfaceDescriptorFunctionType(
Zone* zone = isolate->interface_descriptor_zone();
Type::FunctionType* function =
Type::FunctionType::New(AnyTagged(zone), Type::Undefined(), 2, zone);
- function->InitParameter(0, UntaggedSigned32(zone));
+ function->InitParameter(0, UntaggedIntegral32(zone));
function->InitParameter(1, AnyTagged(zone));
return function;
}
@@ -422,7 +422,7 @@ CallTrampolineDescriptor::BuildCallInterfaceDescriptorFunctionType(
Type::FunctionType::New(AnyTagged(zone), Type::Undefined(), 2, zone);
function->InitParameter(0, AnyTagged(zone)); // target
function->InitParameter(
- 1, UntaggedSigned32(zone)); // actual number of arguments
+ 1, UntaggedIntegral32(zone)); // actual number of arguments
return function;
}
@@ -460,7 +460,7 @@ ArrayConstructorDescriptor::BuildCallInterfaceDescriptorFunctionType(
Type::FunctionType::New(AnyTagged(zone), Type::Undefined(), 3, zone);
function->InitParameter(0, Type::Receiver()); // JSFunction
function->InitParameter(1, AnyTagged(zone));
- function->InitParameter(2, UntaggedSigned32(zone));
+ function->InitParameter(2, UntaggedIntegral32(zone));
return function;
}
@@ -472,7 +472,7 @@ InternalArrayConstructorDescriptor::BuildCallInterfaceDescriptorFunctionType(
Type::FunctionType* function =
Type::FunctionType::New(AnyTagged(zone), Type::Undefined(), 2, zone);
function->InitParameter(0, Type::Receiver()); // JSFunction
- function->InitParameter(1, UntaggedSigned32(zone));
+ function->InitParameter(1, UntaggedIntegral32(zone));
return function;
}
@@ -485,10 +485,10 @@ ArgumentAdaptorDescriptor::BuildCallInterfaceDescriptorFunctionType(
Type::FunctionType::New(AnyTagged(zone), Type::Undefined(), 3, zone);
function->InitParameter(0, Type::Receiver()); // JSFunction
function->InitParameter(
- 1, UntaggedSigned32(zone)); // actual number of arguments
+ 1, UntaggedIntegral32(zone)); // actual number of arguments
function->InitParameter(
2,
- UntaggedSigned32(zone)); // expected number of arguments
+ UntaggedIntegral32(zone)); // expected number of arguments
return function;
}
@@ -504,7 +504,7 @@ ApiFunctionDescriptor::BuildCallInterfaceDescriptorFunctionType(
function->InitParameter(2, AnyTagged(zone)); // holder
function->InitParameter(3, ExternalPointer(zone)); // api_function_address
function->InitParameter(
- 4, UntaggedSigned32(zone)); // actual number of arguments
+ 4, UntaggedIntegral32(zone)); // actual number of arguments
return function;
}
« no previous file with comments | « src/compiler/typer.cc ('k') | src/type-cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698