Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1416913003: Clean up some dead code. (Closed)

Created:
5 years, 2 months ago by mtklein_C
Modified:
5 years, 2 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clean up some dead code. This cleans up tools/ code, or code that should have been in tools/. The only interesting code change trims features off of PictureRenderer. It's still in use by a few useful-looking tools. BUG=skia: Committed: https://skia.googlesource.com/skia/+/0c768a2f330e0e8f0883e174260928097d33e526

Patch Set 1 #

Patch Set 2 : skp2svg #

Patch Set 3 : kill dump-record #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3340 lines) Patch
M BUILD.public View 1 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/tools.gyp View 1 2 7 chunks +16 lines, -125 lines 0 comments Download
D src/svg/skp2svg.cpp View 1 chunk +0 lines, -70 lines 0 comments Download
D tools/CopyTilesRenderer.h View 1 chunk +0 lines, -58 lines 0 comments Download
D tools/CopyTilesRenderer.cpp View 1 chunk +0 lines, -118 lines 0 comments Download
D tools/PictureBenchmark.h View 1 chunk +0 lines, -72 lines 0 comments Download
D tools/PictureBenchmark.cpp View 1 chunk +0 lines, -246 lines 0 comments Download
M tools/PictureRenderer.h View 5 chunks +1 line, -19 lines 0 comments Download
M tools/PictureRenderer.cpp View 4 chunks +2 lines, -97 lines 0 comments Download
D tools/PictureRenderingFlags.h View 1 chunk +0 lines, -33 lines 0 comments Download
D tools/PictureRenderingFlags.cpp View 1 chunk +0 lines, -373 lines 0 comments Download
D tools/PictureResultsWriter.h View 1 chunk +0 lines, -312 lines 0 comments Download
D tools/bench_pictures.cfg View 1 chunk +0 lines, -83 lines 0 comments Download
D tools/bench_pictures_cfg_helper.py View 1 chunk +0 lines, -107 lines 0 comments Download
D tools/bench_pictures_main.cpp View 1 chunk +0 lines, -481 lines 0 comments Download
D tools/chromium/chrome_changes View 1 chunk +0 lines, -7 lines 0 comments Download
D tools/dump_record.cpp View 1 chunk +0 lines, -83 lines 0 comments Download
D tools/flatten.cpp View 1 chunk +0 lines, -51 lines 0 comments Download
D tools/image_expectations.h View 1 chunk +0 lines, -232 lines 0 comments Download
D tools/image_expectations.cpp View 1 chunk +0 lines, -259 lines 0 comments Download
D tools/render_pictures_main.cpp View 1 chunk +0 lines, -511 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416913003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416913003/20001
5 years, 2 months ago (2015-10-20 17:52:52 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/3836)
5 years, 2 months ago (2015-10-20 17:54:41 UTC) #4
mtklein_C
HELP!
5 years, 2 months ago (2015-10-20 20:40:11 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416913003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416913003/40001
5 years, 2 months ago (2015-10-20 20:45:41 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-20 20:57:51 UTC) #10
mtklein_C
5 years, 2 months ago (2015-10-20 21:00:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416913003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416913003/40001
5 years, 2 months ago (2015-10-20 21:00:31 UTC) #14
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 2 months ago (2015-10-20 21:00:32 UTC) #15
reed1
lgtm
5 years, 2 months ago (2015-10-20 21:28:10 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 21:29:13 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/0c768a2f330e0e8f0883e174260928097d33e526

Powered by Google App Engine
This is Rietveld 408576698