content/browser/accessibility/browser_accessibility.h - Issue 1416873015: Text controls should expose their value instead of their name via IAccessibleText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility.h

Issue 1416873015: Text controls should expose their value instead of their name via IAccessibleText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added browser tests and re-introduced IsControl. Expanded unit test. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/accessibility/browser_accessibility.cc » ('j') | content/test/data/accessibility/html/input-radio-in-menu-expected-win.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility.h

diff --git a/content/browser/accessibility/browser_accessibility.h b/content/browser/accessibility/browser_accessibility.h

index 10bde83c4f3db5203b3028425ad448bb930422d3..1dda9acd474e4fd5447ded26b073be1fcc409906 100644

--- a/content/browser/accessibility/browser_accessibility.h

+++ b/content/browser/accessibility/browser_accessibility.h

@@ -274,8 +274,9 @@ class CONTENT_EXPORT BrowserAccessibility {

// True if this is a web area, and its grandparent is a presentational iframe.

bool IsWebAreaForPresentationalIframe() const;

- // Is any control, like a button, text field, etc.

bool IsControl() const;

aboxhall 2015/10/30 19:40:45 Perhaps reinstate the method comment as well?

+ // Indicates whether this is a control with a visible value, like a combo box.

+ bool IsControlWithVisibleValue() const;

protected:

BrowserAccessibility();