Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Side by Side Diff: content/browser/accessibility/browser_accessibility.h

Issue 1416873015: Text controls should expose their value instead of their name via IAccessibleText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added browser tests and re-introduced IsControl. Expanded unit test. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_H_ 5 #ifndef CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_H_
6 #define CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_H_ 6 #define CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_H_
7 7
8 #include <map> 8 #include <map>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 267
268 // Returns true if the caret is active on this object. 268 // Returns true if the caret is active on this object.
269 bool HasCaret() const; 269 bool HasCaret() const;
270 270
271 // Returns true if this node is an editable text field of any kind. 271 // Returns true if this node is an editable text field of any kind.
272 bool IsEditableText() const; 272 bool IsEditableText() const;
273 273
274 // True if this is a web area, and its grandparent is a presentational iframe. 274 // True if this is a web area, and its grandparent is a presentational iframe.
275 bool IsWebAreaForPresentationalIframe() const; 275 bool IsWebAreaForPresentationalIframe() const;
276 276
277 // Is any control, like a button, text field, etc.
278 bool IsControl() const; 277 bool IsControl() const;
aboxhall 2015/10/30 19:40:45 Perhaps reinstate the method comment as well?
278 // Indicates whether this is a control with a visible value, like a combo box.
279 bool IsControlWithVisibleValue() const;
279 280
280 protected: 281 protected:
281 BrowserAccessibility(); 282 BrowserAccessibility();
282 283
283 // The manager of this tree of accessibility objects. 284 // The manager of this tree of accessibility objects.
284 BrowserAccessibilityManager* manager_; 285 BrowserAccessibilityManager* manager_;
285 286
286 // The underlying node. 287 // The underlying node.
287 ui::AXNode* node_; 288 ui::AXNode* node_;
288 289
(...skipping 12 matching lines...) Expand all
301 // its nearest scrollable ancestor) to local bounds (which are relative 302 // its nearest scrollable ancestor) to local bounds (which are relative
302 // to the top of the web accessibility tree). 303 // to the top of the web accessibility tree).
303 gfx::Rect ElementBoundsToLocalBounds(gfx::Rect bounds) const; 304 gfx::Rect ElementBoundsToLocalBounds(gfx::Rect bounds) const;
304 305
305 DISALLOW_COPY_AND_ASSIGN(BrowserAccessibility); 306 DISALLOW_COPY_AND_ASSIGN(BrowserAccessibility);
306 }; 307 };
307 308
308 } // namespace content 309 } // namespace content
309 310
310 #endif // CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_H_ 311 #endif // CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698