Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1416843004: [Editing][BugFix] Fix if condition in ReplaceSelectionCommand (Closed)

Created:
5 years, 1 month ago by yoichio
Modified:
5 years, 1 month ago
Reviewers:
CC:
chromium-reviews, blink-reviews, asanka, benjhayden+dwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2526
Target Ref:
refs/pending/branch-heads/2526
Project:
chromium
Visibility:
Public.

Description

[Editing][BugFix] Fix if condition in ReplaceSelectionCommand In ReplaceSelectionCommand::doApply, we run exec BreakBlockquoteCommand to break a Mail block quote and assume BR element is inserted at endingSelection.start. Then we remove the BR element. This command is run if selection is start in a mail blockquote element. However, selection start can be modified before L1006 because of deleting selection to prepare for insertion. This CL checks the condition again. Plus, refactoring code flow. BUG=534617 Review URL: https://codereview.chromium.org/1395693009 Cr-Commit-Position: refs/heads/master@{#355497} (cherry picked from commit 41f2fa33e2126633ba36e61eed9abb365990bd49) Committed: https://chromium.googlesource.com/chromium/src/+/761db0fc20eaf195e66909f904a317b18b493615

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -23 lines) Patch
A third_party/WebKit/LayoutTests/editing/execCommand/replace-crossing-mailblockquote-crash.html View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 3 chunks +17 lines, -23 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
yoichio
5 years, 1 month ago (2015-10-30 07:00:21 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
761db0fc20eaf195e66909f904a317b18b493615 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698