Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 1416833004: Make bin/c and bin/compare work on Windows. (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
herb_g
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make bin/c and bin/compare work on Windows. - Call python explicitly. - Drop numpy dependency (on numpy.mean.... come on.) - Make scipy dependency optional. Depends on https://codereview.chromium.org/1419073003 to really work. BUG=skia: Doesn't change code. NOTRY=true Committed: https://skia.googlesource.com/skia/+/24a592c2ef586eaffefab068fdf94c284ae80e57

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M bin/c View 1 chunk +3 lines, -3 lines 0 comments Download
M bin/compare View 2 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mtklein_C
5 years, 1 month ago (2015-10-28 16:30:42 UTC) #2
herb_g
lgtm
5 years, 1 month ago (2015-10-28 16:43:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416833004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416833004/1
5 years, 1 month ago (2015-10-28 16:45:07 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 16:45:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/24a592c2ef586eaffefab068fdf94c284ae80e57

Powered by Google App Engine
This is Rietveld 408576698