Implement implicit constructors in mixin applications.

sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
index cb9a7dd8c0f4b13e042f849f0047fb6b79765711..4fe7490bc3f6e01dc0cee5b6c987631902ee92c4 100644
--- a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
+++ b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
@@ -1305,9 +1305,11 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
 
       // Build the initializers in the context of the new constructor.
       TreeElements oldElements = elements;
+      if (constructor.isForwardingConstructor) {

[kasperl, 2013/04/25 12:13:12]

How does this work if the target constructor is a forwarding constructor too?
Can that happen? Are they short-circuited somewhere? You may want to assert that
constructor isn't a forwarding constructor after this.

[karlklose, 2013/05/03 09:35:45]

They are  now short-circuited.

+        constructor = constructor.targetConstructor;
+      }
       elements =
           compiler.enqueuer.resolution.getCachedElements(constructor);
-
       ClosureClassMap oldClosureData = localsHandler.closureData;
       Node node = constructor.parseNode(compiler);
       ClosureClassMap newClosureData =
@@ -2883,6 +2885,10 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
       return pop();
     }
 
+    if (element.isForwardingConstructor) {

[kasperl, 2013/04/25 12:13:12]

Same comment as above.

[karlklose, 2013/05/03 09:35:45]

Done.

[karlklose, 2013/05/03 09:35:45]

I added an invariant when they are created.

+      element = element.targetConstructor;
+    }
+
     return selector.addArgumentsToList(arguments,
                                        list,
                                        element,
@@ -3378,6 +3384,10 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
 
     Element constructor = elements[node];
     Selector selector = elements.getSelector(node);
+    if (constructor.isForwardingConstructor) {
+      compiler.unimplemented('forwarded constructor in named mixin application',
+                             element: constructor.getEnclosingClass());
+    }
     if (compiler.enqueuer.resolution.getCachedElements(constructor) == null) {
       compiler.internalError("Unresolved element: $constructor", node: node);
     }