Implement implicit constructors in mixin applications.

sdk/lib/_internal/compiler/implementation/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 /**
  * A special element for the extra parameter taken by intercepted
  * methods. We need to override [Element.computeType] because our
  * optimizers may look at its declared type.
@@ skipping 1287 matching lines @@
         // Don't forget to update the field, if the parameter is of the
         // form [:this.x:].
         if (parameter.kind == ElementKind.FIELD_PARAMETER) {
           FieldParameterElement fieldParameterElement = parameter;
           fieldValues[fieldParameterElement.fieldElement] = argument;
         }
       });
 
       // Build the initializers in the context of the new constructor.
       TreeElements oldElements = elements;
+      if (constructor.isForwardingConstructor) {

[kasperl, 2013/04/25 12:13:12]

How does this work if the target constructor is a forwarding constructor too?
Can that happen? Are they short-circuited somewhere? You may want to assert that
constructor isn't a forwarding constructor after this.

[karlklose, 2013/05/03 09:35:45]

They are  now short-circuited.

+        constructor = constructor.targetConstructor;
+      }
       elements =
           compiler.enqueuer.resolution.getCachedElements(constructor);
-
       ClosureClassMap oldClosureData = localsHandler.closureData;
       Node node = constructor.parseNode(compiler);
       ClosureClassMap newClosureData =
           compiler.closureToClassMapper.computeClosureToClassMapping(
               constructor, node, elements);
       // The [:this:] element now refers to the one in the new closure
       // data, that is the [:this:] of the super constructor. We
       // update the element to refer to the current [:this:].
       localsHandler.updateLocal(newClosureData.thisElement,
                                 localsHandler.readThis());
@@ skipping 1555 matching lines @@
                                     Link<Node> arguments,
                                     FunctionElement element,
                                     List<HInstruction> list) {
     assert(invariant(element, element.isImplementation));
 
     HInstruction compileArgument(Node argument) {
       visit(argument);
       return pop();
     }
 
+    if (element.isForwardingConstructor) {

[kasperl, 2013/04/25 12:13:12]

Same comment as above.

[karlklose, 2013/05/03 09:35:45]

Done.

[karlklose, 2013/05/03 09:35:45]

I added an invariant when they are created.

+      element = element.targetConstructor;
+    }
+
     return selector.addArgumentsToList(arguments,
                                        list,
                                        element,
                                        compileArgument,
                                        handleConstantForOptionalParameter,
                                        compiler);
   }
 
   void addGenericSendArgumentsToList(Link<Node> link, List<HInstruction> list) {
     for (; !link.isEmpty; link = link.tail) {
@@ skipping 475 matching lines @@
       } else if (element.isGenerativeConstructor()) {
         ClassElement cls = element.getEnclosingClass();
         return new HType.nonNullExact(cls.thisType, compiler);
       } else {
         return HType.UNKNOWN;
       }
     }
 
     Element constructor = elements[node];
     Selector selector = elements.getSelector(node);
+    if (constructor.isForwardingConstructor) {
+      compiler.unimplemented('forwarded constructor in named mixin application',
+                             element: constructor.getEnclosingClass());
+    }
     if (compiler.enqueuer.resolution.getCachedElements(constructor) == null) {
       compiler.internalError("Unresolved element: $constructor", node: node);
     }
     FunctionElement functionElement = constructor;
     constructor = functionElement.redirectionTarget;
     final bool isSymbolConstructor =
         functionElement == compiler.symbolConstructor;
 
     if (isSymbolConstructor) {
       constructor = compiler.symbolValidatedConstructor;
@@ skipping 1857 matching lines @@
           new HSubGraphBlockInformation(elseBranch.graph));
 
     HBasicBlock conditionStartBlock = conditionBranch.block;
     conditionStartBlock.setBlockFlow(info, joinBlock);
     SubGraph conditionGraph = conditionBranch.graph;
     HIf branch = conditionGraph.end.last;
     assert(branch is HIf);
     branch.blockInformation = conditionStartBlock.blockFlow;
   }
 }