Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1416713002: Consolidate test support code. (Closed)

Created:
5 years, 2 months ago by Tom Sepez
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com, dsinclair
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Consolidate test support code. Removes duplication between pdfium_test and pdfium_embeddertest R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6d34d056a7188b7ae9800fe3ceb68645e0442879

Patch Set 1 #

Patch Set 2 : IWYU #

Total comments: 2

Patch Set 3 : test_support target. #

Patch Set 4 : The testonly = true game. #

Patch Set 5 : GN is picky about multiple mains #

Patch Set 6 : GN missing files. #

Patch Set 7 : Duplicated lines in GN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -232 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 3 chunks +35 lines, -4 lines 0 comments Download
M pdfium.gyp View 1 2 3 4 4 chunks +31 lines, -2 lines 0 comments Download
M samples/BUILD.gn View 1 2 3 4 chunks +6 lines, -1 line 0 comments Download
M samples/pdfium_test.cc View 1 6 chunks +8 lines, -113 lines 0 comments Download
M samples/samples.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M testing/embedder_test.cpp View 5 chunks +6 lines, -112 lines 0 comments Download
A testing/test_support.h View 1 chunk +44 lines, -0 lines 0 comments Download
A testing/test_support.cpp View 1 chunk +140 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Tom Sepez
Lei, for review. Dan, FYI for pdfium_shell use.
5 years, 2 months ago (2015-10-19 18:37:27 UTC) #2
dsinclair
https://codereview.chromium.org/1416713002/diff/20001/testing/test_support.h File testing/test_support.h (right): https://codereview.chromium.org/1416713002/diff/20001/testing/test_support.h#newcode15 testing/test_support.h:15: What's the PDFium stance on namespaces? Should this all ...
5 years, 2 months ago (2015-10-19 18:49:48 UTC) #4
Lei Zhang
Can test_support be its own target?
5 years, 2 months ago (2015-10-19 18:51:26 UTC) #5
Tom Sepez
https://codereview.chromium.org/1416713002/diff/20001/testing/test_support.h File testing/test_support.h (right): https://codereview.chromium.org/1416713002/diff/20001/testing/test_support.h#newcode15 testing/test_support.h:15: On 2015/10/19 18:49:48, dsinclair wrote: > What's the PDFium ...
5 years, 2 months ago (2015-10-19 18:57:36 UTC) #6
Tom Sepez
On 2015/10/19 18:51:26, Lei Zhang wrote: > Can test_support be its own target? Done.
5 years, 2 months ago (2015-10-19 19:17:09 UTC) #7
Lei Zhang
lgtm
5 years, 2 months ago (2015-10-19 19:21:43 UTC) #8
Tom Sepez
5 years, 2 months ago (2015-10-19 21:03:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as
6d34d056a7188b7ae9800fe3ceb68645e0442879 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698