Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: BUILD.gn

Issue 1416713002: Consolidate test support code. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Duplicated lines in GN Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pdfium.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 8ae5a085f02f9011e69b4579e274a7af7f0fecfa..ea53caed64fbb0de51c8774387bf431de35ce538 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -133,6 +133,39 @@ static_library("pdfium") {
}
}
+source_set("test_support") {
+ testonly = true
+ sources = [
+ "testing/fx_string_testhelpers.cpp",
+ "testing/fx_string_testhelpers.h",
+ "testing/test_support.cpp",
+ "testing/test_support.h",
+ ]
+ deps = [
+ "//testing/gmock",
+ "//testing/gtest",
+ ":pdfium",
+ ]
+ include_dirs = [
+ "."
+ ]
+ if (pdf_enable_v8) {
+ deps += [
+ "//v8",
+ "//v8:v8_libplatform",
+ ]
+ include_dirs += [
+ "//v8",
+ "//v8/include",
+ ]
+ }
+ configs -= [ "//build/config/compiler:chromium_code" ]
+ configs += [
+ ":pdfium_config",
+ "//build/config/compiler:no_chromium_code",
+ ]
+}
+
# Targets below this are only visible within this file (and to the
# top-level gn_visibility target used to help gn_all build everything).
visibility = [
@@ -731,14 +764,13 @@ test("pdfium_unittests") {
"core/src/fxcrt/fx_basic_wstring_unittest.cpp",
"core/src/fxcrt/fx_bidi_unittest.cpp",
"core/src/fxcrt/fx_system_unittest.cpp",
- "testing/fx_string_testhelpers.cpp",
- "testing/fx_string_testhelpers.h",
"third_party/base/nonstd_unique_ptr_unittest.cpp",
]
deps = [
"//testing/gtest",
"//testing/gtest:gtest_main",
":pdfium",
+ ":test_support",
]
include_dirs = [ "." ]
configs -= [ "//build/config/compiler:chromium_code" ]
@@ -763,13 +795,12 @@ test("pdfium_embeddertests") {
"testing/embedder_test.h",
"testing/embedder_test_mock_delegate.h",
"testing/embedder_test_timer_handling_delegate.h",
- "testing/fx_string_testhelpers.cpp",
- "testing/fx_string_testhelpers.h",
]
deps = [
"//testing/gmock",
"//testing/gtest",
":pdfium",
+ ":test_support",
]
include_dirs = [
"."
« no previous file with comments | « no previous file | pdfium.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698