Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 1416583002: Revert of Always give class literals a block scope (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com, rossberg
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Always give class literals a block scope (patchset #2 id:20001 of https://codereview.chromium.org/1413903002/ ) Reason for revert: [Sheriff] Breaks vector stores: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug%20-%20vector%20stores/builds/536 Original issue's description: > Always give class literals a block scope > > Class methods always have the class scope on their scope chain in order > to implement strong mode checks. Previously, that scope wasn't attached > to the ClassLiteral for anonymous classes (since the scope contained > no bindings). > > This patch simply puts that same scope on the ClassLiteral, anonymous > or not, which simplifies other code that needs to reason about the scope > of a class and its methods. > > Committed: https://crrev.com/cf13dda1ba25e8293ea143f33c6c5f6233a39c86 > Cr-Commit-Position: refs/heads/master@{#31371} TBR=mstarzinger@chromium.org,adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/8aec6fb0470dff7f110c54e22684a7907c82e2c7 Cr-Commit-Position: refs/heads/master@{#31373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -11 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +14 lines, -8 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/parser.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
Created Revert of Always give class literals a block scope
5 years, 2 months ago (2015-10-19 12:16:47 UTC) #1
Michael Achenbach
+ mvstanton
5 years, 2 months ago (2015-10-19 12:17:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416583002/1
5 years, 2 months ago (2015-10-19 12:17:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 12:17:28 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 12:17:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8aec6fb0470dff7f110c54e22684a7907c82e2c7
Cr-Commit-Position: refs/heads/master@{#31373}

Powered by Google App Engine
This is Rietveld 408576698