Remaining issues with making the autofill dialog usable

Remaining issues with making the autofill dialog usable

This fixes the initialization so that updating menu items dont trigger
layout changes. It makes the dialog resize on keyboard coming up and down.
It also adds an email layout so that we have a valid(although non-ideal)
transition for all sections. The transition will be fixed properly on
crbug.com/180980

BUG=226500, 226496, 226497
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193732

[aruslan, 2013-04-11 17:55:42]

lgtm.

[nilesh, 2013-04-11 18:16:38]

https://codereview.chromium.org/14165005/diff/1/chrome/android/java/src/org/c...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java
(right):

https://codereview.chromium.org/14165005/diff/1/chrome/android/java/src/org/c...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java:369:
public AutofillDialogEmailMenuAdapter(Context context, List<String> objects) {
objects?  
emails/email_list or something more specific.

https://codereview.chromium.org/14165005/diff/1/chrome/android/java/src/org/c...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java:379:
String item = getItem(position);
what does this do?

[Yusuf, 2013-04-11 18:20:38]

https://codereview.chromium.org/14165005/diff/1/chrome/android/java/src/org/c...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java
(right):

https://codereview.chromium.org/14165005/diff/1/chrome/android/java/src/org/c...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java:369:
public AutofillDialogEmailMenuAdapter(Context context, List<String> objects) {
Sorry this adapter class was my initial idea of giving the use an option to edit
email. But I ended up using a separate layout instead. I have removed this class
in the new patch.


On 2013/04/11 18:16:39, nilesh wrote:
> objects?  
> emails/email_list or something more specific.

[nilesh, 2013-04-11 18:37:59]

LGTM with nits

https://codereview.chromium.org/14165005/diff/5002/chrome/android/java/src/or...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java
(right):

https://codereview.chromium.org/14165005/diff/5002/chrome/android/java/src/or...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java:49:
// TODO(yusufo): Remove all placeholders here and also in related layout xml
files.
is the TODO still relevant

https://codereview.chromium.org/14165005/diff/5002/chrome/android/java/src/or...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java:216:
spinner.setOnItemSelectedListener(null);
Please add a comment on why we need to null the selected listener.

[Yusuf, 2013-04-11 18:44:19]

https://codereview.chromium.org/14165005/diff/5002/chrome/android/java/src/or...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java
(right):

https://codereview.chromium.org/14165005/diff/5002/chrome/android/java/src/or...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java:49:
// TODO(yusufo): Remove all placeholders here and also in related layout xml
files.
On 2013/04/11 18:37:59, nilesh wrote:
> is the TODO still relevant

Done.

https://codereview.chromium.org/14165005/diff/5002/chrome/android/java/src/or...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java:216:
spinner.setOnItemSelectedListener(null);
On 2013/04/11 18:37:59, nilesh wrote:
> Please add a comment on why we need to null the selected listener.

Done.

[commit-bot: I haz the power, 2013-04-11 20:25:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusufo@chromium.org/14165005/8001

[commit-bot: I haz the power, 2013-04-11 20:28:58]

Change committed as 193732