Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4756)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogUtils.java

Issue 14165005: Remaining issues with making the autofill dialog usable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nit fixes Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogUtils.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogUtils.java
index 1ede21677244cae7018fd55758f95787f65526d3..7c307471c918b585d15b6bc50b412d7dbeab294b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogUtils.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogUtils.java
@@ -86,7 +86,7 @@ public class AutofillDialogUtils {
case AutofillDialogConstants.SECTION_BILLING :
return R.id.editing_layout_billing;
case AutofillDialogConstants.SECTION_EMAIL :
- return INVALID_ID;
+ return R.id.editing_layout_email;
default:
assert(false);
return INVALID_ID;
@@ -127,7 +127,8 @@ public class AutofillDialogUtils {
public static int getViewIDForField(int section, int field) {
switch (section) {
case AutofillDialogConstants.SECTION_EMAIL :
- return 0;
+ assert(field == AutofillDialogConstants.EMAIL_ADDRESS);
+ return R.id.email_address;
case AutofillDialogConstants.SECTION_CC :
switch (field) {
case AutofillDialogConstants.CREDIT_CARD_NUMBER :
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698