Add support for Xcode LastUpgradeCheck project attributes, allowing

Add support for Xcode LastUpgradeCheck project attributes, allowing
suppression of Xcode project configuration warnings.

BUG=
R=mark@chromium.org

Committed: https://chromium.googlesource.com/external/gyp/+/e2e928bacd07fead99a18cb08d64cb24e131d3e5

[aharper, 2015-10-21 00:30:58]

Description was changed from

==========
Add support for Xcode LastUpgradeCheck project attributes, allowing
suppression of Xcode project configuration warnings.

BUG=
==========

to

==========
Add support for Xcode LastUpgradeCheck project attributes, allowing
suppression of Xcode project configuration warnings.

BUG=
==========

[aharper, 2015-10-21 00:30:58]

aharper@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2015-10-21 00:34:25]

https://codereview.chromium.org/1416453003/diff/20001/pylib/gyp/generator/xco...
File pylib/gyp/generator/xcode.py (right):

https://codereview.chromium.org/1416453003/diff/20001/pylib/gyp/generator/xco...
pylib/gyp/generator/xcode.py:594: upgrade_check_project_version = \
= int(generator_flags.get(…))

to make sure that it’s an int, since the 0-appending thing you do kind of
assumes that it’s a number.

[aharper, 2015-10-21 00:39:19]

https://codereview.chromium.org/1416453003/diff/20001/pylib/gyp/generator/xco...
File pylib/gyp/generator/xcode.py (right):

https://codereview.chromium.org/1416453003/diff/20001/pylib/gyp/generator/xco...
pylib/gyp/generator/xcode.py:594: upgrade_check_project_version = \
On 2015/10/21 00:34:25, Mark Mentovai wrote:
> = int(generator_flags.get(…))
> 
> to make sure that it’s an int, since the 0-appending thing you do kind of
> assumes that it’s a number.

So the int conversion actually happens in gyp/__init__.py NameValueListToDict().
I actually wanted to suppress that conversion because it eats the leading zero 
but seemed more risky. So this code assumes only that we have a value that can
stringify (line 599) and that we need to pad to 4 chars.

[Mark Mentovai, 2015-10-21 00:44:53]

That explains the str(). LGTM.

[Mark Mentovai, 2015-10-21 00:46:29]

Committed patchset #2 (id:20001) manually as
e2e928bacd07fead99a18cb08d64cb24e131d3e5 (presubmit successful).

[scottmg, 2015-11-03 23:34:56]

I believe this causes iOS Simulator to fail when I roll into Chrome:

http://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/bui...

________ running '/usr/bin/python src/build/gyp_chromium' in
'/b/build/slave/iOS_Simulator__dbg_/build'
Updating projects from gyp files...
Using overrides found in /Users/chrome-bot/.gyp/include.gypi
Traceback (most recent call last):
  File "src/build/gyp_chromium", line 12, in <module>
    execfile(__file__ + '.py')
  File "src/build/gyp_chromium.py", line 336, in <module>
    sys.exit(main())
  File "src/build/gyp_chromium.py", line 323, in main
    gyp_rc = gyp.main(args)
  File
"/b/build/slave/iOS_Simulator__dbg_/build/src/tools/gyp/pylib/gyp/__init__.py",
line 538, in main
    return gyp_main(args)
  File
"/b/build/slave/iOS_Simulator__dbg_/build/src/tools/gyp/pylib/gyp/__init__.py",
line 523, in gyp_main
    generator.GenerateOutput(flat_list, targets, data, params)
  File
"/b/build/slave/iOS_Simulator__dbg_/build/src/tools/gyp/pylib/gyp/generator/xcode.py",
line 630, in GenerateOutput
    xcp.project_file.SetXcodeVersion(project_version)
AttributeError: 'XCProjectFile' object has no attribute 'SetXcodeVersion'
Error: Command '/usr/bin/python src/build/gyp_chromium' returned non-zero exit
status 1 in /b/build/slave/iOS_Simulator__dbg_/build
Hook '/usr/bin/python src/build/gyp_chromium' took 14.91 secs

[scottmg, 2015-11-03 23:37:01]

On 2015/11/03 23:34:56, scottmg wrote:
> I believe this causes iOS Simulator to fail when I roll into Chrome:
> 
>
http://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/bui...
> 
> ________ running '/usr/bin/python src/build/gyp_chromium' in
> '/b/build/slave/iOS_Simulator__dbg_/build'
> Updating projects from gyp files...
> Using overrides found in /Users/chrome-bot/.gyp/include.gypi
> Traceback (most recent call last):
>   File "src/build/gyp_chromium", line 12, in <module>
>     execfile(__file__ + '.py')
>   File "src/build/gyp_chromium.py", line 336, in <module>
>     sys.exit(main())
>   File "src/build/gyp_chromium.py", line 323, in main
>     gyp_rc = gyp.main(args)
>   File
>
"/b/build/slave/iOS_Simulator__dbg_/build/src/tools/gyp/pylib/gyp/__init__.py",
> line 538, in main
>     return gyp_main(args)
>   File
>
"/b/build/slave/iOS_Simulator__dbg_/build/src/tools/gyp/pylib/gyp/__init__.py",
> line 523, in gyp_main
>     generator.GenerateOutput(flat_list, targets, data, params)
>   File
>
"/b/build/slave/iOS_Simulator__dbg_/build/src/tools/gyp/pylib/gyp/generator/xcode.py",
> line 630, in GenerateOutput
>     xcp.project_file.SetXcodeVersion(project_version)
> AttributeError: 'XCProjectFile' object has no attribute 'SetXcodeVersion'
> Error: Command '/usr/bin/python src/build/gyp_chromium' returned non-zero exit
> status 1 in /b/build/slave/iOS_Simulator__dbg_/build
> Hook '/usr/bin/python src/build/gyp_chromium' took 14.91 secs

I don't see any SetXcodeVersion at all? Was it supposed to be added in this
patch?

[scottmg, 2015-11-03 23:42:15]

On 2015/11/03 23:37:01, scottmg wrote:
> On 2015/11/03 23:34:56, scottmg wrote:
> > I believe this causes iOS Simulator to fail when I roll into Chrome:
> > 
> >
>
http://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/bui...
> > 
> > ________ running '/usr/bin/python src/build/gyp_chromium' in
> > '/b/build/slave/iOS_Simulator__dbg_/build'
> > Updating projects from gyp files...
> > Using overrides found in /Users/chrome-bot/.gyp/include.gypi
> > Traceback (most recent call last):
> >   File "src/build/gyp_chromium", line 12, in <module>
> >     execfile(__file__ + '.py')
> >   File "src/build/gyp_chromium.py", line 336, in <module>
> >     sys.exit(main())
> >   File "src/build/gyp_chromium.py", line 323, in main
> >     gyp_rc = gyp.main(args)
> >   File
> >
>
"/b/build/slave/iOS_Simulator__dbg_/build/src/tools/gyp/pylib/gyp/__init__.py",
> > line 538, in main
> >     return gyp_main(args)
> >   File
> >
>
"/b/build/slave/iOS_Simulator__dbg_/build/src/tools/gyp/pylib/gyp/__init__.py",
> > line 523, in gyp_main
> >     generator.GenerateOutput(flat_list, targets, data, params)
> >   File
> >
>
"/b/build/slave/iOS_Simulator__dbg_/build/src/tools/gyp/pylib/gyp/generator/xcode.py",
> > line 630, in GenerateOutput
> >     xcp.project_file.SetXcodeVersion(project_version)
> > AttributeError: 'XCProjectFile' object has no attribute 'SetXcodeVersion'
> > Error: Command '/usr/bin/python src/build/gyp_chromium' returned non-zero
exit
> > status 1 in /b/build/slave/iOS_Simulator__dbg_/build
> > Hook '/usr/bin/python src/build/gyp_chromium' took 14.91 secs
> 
> I don't see any SetXcodeVersion at all? Was it supposed to be added in this
> patch?

I'm going to revert, as I need to roll gyp to fix another problem. Should
hopefully be a simple reland.