Add support for Xcode LastUpgradeCheck project attributes, allowing

pylib/gyp/generator/xcode.py

 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import filecmp
 import gyp.common
 import gyp.xcodeproj_file
 import gyp.xcode_ninja
 import errno
 import os
@@ skipping 572 matching lines @@
   ninja_wrapper = params.get('flavor') == 'ninja'
   if ninja_wrapper:
     (target_list, target_dicts, data) = \
         gyp.xcode_ninja.CreateWrapper(target_list, target_dicts, data, params)
 
   options = params['options']
   generator_flags = params.get('generator_flags', {})
   parallel_builds = generator_flags.get('xcode_parallel_builds', True)
   serialize_all_tests = \
       generator_flags.get('xcode_serialize_all_test_runs', True)
+  project_version = generator_flags.get('xcode_project_version', None)
+  upgrade_check_project_version = \

[Mark Mentovai, 2015/10/21 00:34:25]

= int(generator_flags.get(…))

to make sure that it’s an int, since the 0-appending thing you do kind of
assumes that it’s a number.

[aharper, 2015/10/21 00:39:19]

So the int conversion actually happens in gyp/__init__.py NameValueListToDict().
I actually wanted to suppress that conversion because it eats the leading zero 
but seemed more risky. So this code assumes only that we have a value that can
stringify (line 599) and that we need to pad to 4 chars.

+      generator_flags.get('xcode_upgrade_check_project_version', None)
+
+  # Format upgrade_check_project_version with leading zeros as needed.
+  if upgrade_check_project_version:
+    upgrade_check_project_version = str(upgrade_check_project_version)
+    while len(upgrade_check_project_version) < 4:
+      upgrade_check_project_version = '0' + upgrade_check_project_version
+
   skip_excluded_files = \
       not generator_flags.get('xcode_list_excluded_files', True)
   xcode_projects = {}
   for build_file, build_file_dict in data.iteritems():
     (build_file_root, build_file_ext) = os.path.splitext(build_file)
     if build_file_ext != '.gyp':
       continue
     xcodeproj_path = build_file_root + options.suffix + '.xcodeproj'
     if options.generator_output:
       xcodeproj_path = os.path.join(options.generator_output, xcodeproj_path)
     xcp = XcodeProject(build_file, xcodeproj_path, build_file_dict)
     xcode_projects[build_file] = xcp
     pbxp = xcp.project
 
+    # Set project-level attributes from multiple options
+    project_attributes = {};
     if parallel_builds:
-      pbxp.SetProperty('attributes',
-                       {'BuildIndependentTargetsInParallel': 'YES'})
+      project_attributes['BuildIndependentTargetsInParallel'] = 'YES'
+    if upgrade_check_project_version:
+      project_attributes['LastUpgradeCheck'] = upgrade_check_project_version
+      project_attributes['LastTestingUpgradeCheck'] = \
+          upgrade_check_project_version
+    pbxp.SetProperty('attributes', project_attributes)
+
+    if project_version:
+      xcp.project_file.SetXcodeVersion(project_version)
 
     # Add gyp/gypi files to project
     if not generator_flags.get('standalone'):
       main_group = pbxp.GetProperty('mainGroup')
       build_group = gyp.xcodeproj_file.PBXGroup({'name': 'Build'})
       main_group.AppendChild(build_group)
       for included_file in build_file_dict['included_files']:
         build_group.AddOrGetFileByPath(included_file, False)
 
   xcode_targets = {}
@@ skipping 629 matching lines @@
 
   for build_file in build_files:
     xcode_projects[build_file].Finalize1(xcode_targets, serialize_all_tests)
 
   for build_file in build_files:
     xcode_projects[build_file].Finalize2(xcode_targets,
                                          xcode_target_to_target_dict)
 
   for build_file in build_files:
     xcode_projects[build_file].Write()