Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1416303007: Partial revert of r357449 to keep Flash 19.x working. (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
bbudge, Xing, binji
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, jam, teravest+watch_chromium.org, darin-cc_chromium.org, bradnelson+warch_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Partial revert of r357449 to keep Flash 19.x working. BUG=551093 Committed: https://crrev.com/ab637b451ef1c83c1571dbb2d77a60e5b18b8813 Cr-Commit-Position: refs/heads/master@{#357968}

Patch Set 1 #

Patch Set 2 : ignore #

Patch Set 3 : rebase #

Patch Set 4 : with idl file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -121 lines) Patch
M chrome/common/ppapi_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/pepper/plugin_module.cc View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/verify_ppapi.py View 1 1 chunk +2 lines, -1 line 0 comments Download
A + ppapi/api/dev/ppb_font_dev.idl View 1 2 3 11 chunks +50 lines, -50 lines 0 comments Download
A + ppapi/c/dev/ppb_font_dev.h View 13 chunks +66 lines, -70 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_private.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (8 generated)
Lei Zhang
This is the minimum revert to fix the bug. I also get the following presubmit ...
5 years, 1 month ago (2015-11-04 03:59:17 UTC) #2
Lei Zhang
On 2015/11/04 03:59:17, Lei Zhang wrote: > This is the minimum revert to fix the ...
5 years, 1 month ago (2015-11-04 06:19:04 UTC) #3
Lei Zhang
Xing, can I also get your blessing on this? When we are ready in the ...
5 years, 1 month ago (2015-11-04 19:17:13 UTC) #5
binji
On 2015/11/04 06:19:04, Lei Zhang wrote: > On 2015/11/04 03:59:17, Lei Zhang wrote: > > ...
5 years, 1 month ago (2015-11-04 19:44:46 UTC) #6
Xing
lgtm LGTM this should work around the problem
5 years, 1 month ago (2015-11-04 19:46:52 UTC) #7
bbudge
LGTM Hopefully the presubmit checks won't be a pain.
5 years, 1 month ago (2015-11-04 21:14:30 UTC) #8
Lei Zhang
On 2015/11/04 19:44:46, binji wrote: > I started the linux_nacl_sdk trybot. If it passes, you ...
5 years, 1 month ago (2015-11-04 21:57:27 UTC) #9
Lei Zhang
And +binji as a reviewer.
5 years, 1 month ago (2015-11-04 22:14:45 UTC) #11
binji
native_client_sdk lgtm
5 years, 1 month ago (2015-11-04 23:19:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416303007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416303007/40001
5 years, 1 month ago (2015-11-04 23:30:17 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/115670)
5 years, 1 month ago (2015-11-05 00:02:14 UTC) #17
Lei Zhang
On 2015/11/05 00:02:14, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 1 month ago (2015-11-05 00:09:15 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416303007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416303007/60001
5 years, 1 month ago (2015-11-05 00:23:01 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-05 01:22:27 UTC) #22
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 01:23:17 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ab637b451ef1c83c1571dbb2d77a60e5b18b8813
Cr-Commit-Position: refs/heads/master@{#357968}

Powered by Google App Engine
This is Rietveld 408576698