Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: native_client_sdk/src/build_tools/verify_ppapi.py

Issue 1416303007: Partial revert of r357449 to keep Flash 19.x working. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: with idl file Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/pepper/plugin_module.cc ('k') | ppapi/api/dev/ppb_font_dev.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Helper script for PPAPI's PRESUBMIT.py to detect if additions or removals of 6 """Helper script for PPAPI's PRESUBMIT.py to detect if additions or removals of
7 PPAPI interfaces have been propagated to the Native Client libraries (.dsc 7 PPAPI interfaces have been propagated to the Native Client libraries (.dsc
8 files). 8 files).
9 9
10 For example, if a user adds "ppapi/c/foo.h", we check that the interface has 10 For example, if a user adds "ppapi/c/foo.h", we check that the interface has
11 been added to "native_client_sdk/src/libraries/ppapi/library.dsc". 11 been added to "native_client_sdk/src/libraries/ppapi/library.dsc".
12 """ 12 """
13 13
14 import argparse 14 import argparse
15 import os 15 import os
16 import sys 16 import sys
17 17
18 from build_paths import PPAPI_DIR, SRC_DIR, SDK_LIBRARY_DIR 18 from build_paths import PPAPI_DIR, SRC_DIR, SDK_LIBRARY_DIR
19 import parse_dsc 19 import parse_dsc
20 20
21 21
22 # Add a file to this list if it should not be added to a .dsc file; i.e. if it 22 # Add a file to this list if it should not be added to a .dsc file; i.e. if it
23 # should not be included in the Native Client SDK. This will silence the 23 # should not be included in the Native Client SDK. This will silence the
24 # presubmit warning. 24 # presubmit warning.
25 # 25 #
26 # Some examples of files that should not be added to the SDK are: Dev and 26 # Some examples of files that should not be added to the SDK are: Dev and
27 # Private interfaces that are either not available to NaCl plugins or are only 27 # Private interfaces that are either not available to NaCl plugins or are only
28 # available to Flash or other privileged plugins. 28 # available to Flash or other privileged plugins.
29 IGNORED_FILES = set([ 29 IGNORED_FILES = set([
30 'pp_video_dev.h' 30 'ppb_font_dev.h',
31 'pp_video_dev.h',
31 ]) 32 ])
32 33
33 34
34 class VerifyException(Exception): 35 class VerifyException(Exception):
35 def __init__(self, lib_path, expected, unexpected): 36 def __init__(self, lib_path, expected, unexpected):
36 self.expected = expected 37 self.expected = expected
37 self.unexpected = unexpected 38 self.unexpected = unexpected
38 39
39 msg = 'In %s:\n' % lib_path 40 msg = 'In %s:\n' % lib_path
40 if expected: 41 if expected:
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 is_private = lib_name == 'ppapi_cpp_private' 191 is_private = lib_name == 'ppapi_cpp_private'
191 if not VerifyOrPrintError(rel_dsc_filename, dsc_sources_and_headers, 192 if not VerifyOrPrintError(rel_dsc_filename, dsc_sources_and_headers,
192 changed_filenames, removed_filenames, 193 changed_filenames, removed_filenames,
193 is_private=is_private): 194 is_private=is_private):
194 retval = 1 195 retval = 1
195 return retval 196 return retval
196 197
197 198
198 if __name__ == '__main__': 199 if __name__ == '__main__':
199 sys.exit(main(sys.argv[1:])) 200 sys.exit(main(sys.argv[1:]))
OLDNEW
« no previous file with comments | « content/renderer/pepper/plugin_module.cc ('k') | ppapi/api/dev/ppb_font_dev.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698