Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1416293003: Some cleanups to observatory BUILD.gn (Closed)

Created:
5 years, 1 month ago by Cutch
Modified:
5 years, 1 month ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, ricow1, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -10 lines) Patch
M runtime/bin/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/BUILD.gn View 6 chunks +16 lines, -6 lines 0 comments Download
M runtime/tools/create_archive.py View 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Cutch
5 years, 1 month ago (2015-10-26 23:38:32 UTC) #3
rmacnak
lgtm
5 years, 1 month ago (2015-10-26 23:39:53 UTC) #4
Cutch
5 years, 1 month ago (2015-10-27 14:42:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
30e77221bc7580a850ab0b0fe17e965510de9646 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698