Some cleanups to observatory BUILD.gn

runtime/tools/create_archive.py

 # Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 #
 # This python script creates a tar archive and a C++ source file which contains
 # the tar archive as an array of bytes.
 
 import os
 import sys
 from os.path import join, splitext
@@ skipping 22 matching lines @@
                 inner_namespace,
                 name,
                 tar_archive,
                 ):
   cc_text = '''
 // Copyright (c) %d, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 ''' % date.today().year
+  cc_text += '''
+
+#if defined(_WIN32)
+typedef unsigned __int8 uint8_t;
+#else
+#include <inttypes.h>
+#include <stdint.h>
+#endif
+#include <stddef.h>
+
+'''
   cc_text += 'namespace %s {\n' % outer_namespace
   if inner_namespace != None:
     cc_text += 'namespace %s {\n' % inner_namespace
   cc_text += '\n\n'
   # Write the archive.
-  cc_text += 'static const char %s_[] = {\n  ' % name
+  cc_text += 'static const uint8_t %s_[] = {\n  ' % name
   lineCounter = 0
   for byte in tar_archive:
     cc_text += r" '\x%02x'," % ord(byte)
     lineCounter += 1
     if lineCounter == 10:
       cc_text += '\n   '
       lineCounter = 0
   if lineCounter != 0:
     cc_text += '\n   '
   cc_text += '};\n'
   cc_text += '\nunsigned int %s_len = %d;\n' % (name, len(tar_archive))
-  cc_text += '\nconst char* %s = %s_;\n' % (name, name)
+  cc_text += '\nconst uint8_t* %s = %s_;\n' % (name, name)
   if inner_namespace != None:
     cc_text += '}  // namespace %s\n' % inner_namespace
   cc_text += '} // namespace %s\n' % outer_namespace
 
   open(output_file, 'w').write(cc_text)
 
 def main(args):
   try:
     # Parse input.
     parser = OptionParser()
@@ skipping 60 matching lines @@
     return 0
 
   except Exception, inst:
     sys.stderr.write('create_resources.py exception\n')
     sys.stderr.write(str(inst))
     sys.stderr.write('\n')
     return -1
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))