Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1416173002: Fix flaky SitePerProcessBrowserTest.SurfaceHitTestTest test. (Closed)

Created:
5 years, 2 months ago by lfg
Modified:
5 years, 2 months ago
Reviewers:
kenrb, Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky SitePerProcessBrowserTest.SurfaceHitTestTest test. BUG=527618, 528189 Committed: https://crrev.com/9e713e6c00cee68eb7085bdfa17b82c83b47eea6 Cr-Commit-Position: refs/heads/master@{#355577}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M content/browser/site_per_process_browsertest.cc View 1 2 3 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
lfg
Hey Ken, please take a look. There were 3 causes for the flake tests: 1. ...
5 years, 2 months ago (2015-10-22 17:04:31 UTC) #2
kenrb
Thanks for taking this. One minor comment. https://codereview.chromium.org/1416173002/diff/20001/content/browser/site_per_process_browsertest.cc File content/browser/site_per_process_browsertest.cc (right): https://codereview.chromium.org/1416173002/diff/20001/content/browser/site_per_process_browsertest.cc#newcode568 content/browser/site_per_process_browsertest.cc:568: main_frame_monitor.ResetEventReceived(); Can ...
5 years, 2 months ago (2015-10-22 17:17:47 UTC) #3
lfg
https://codereview.chromium.org/1416173002/diff/20001/content/browser/site_per_process_browsertest.cc File content/browser/site_per_process_browsertest.cc (right): https://codereview.chromium.org/1416173002/diff/20001/content/browser/site_per_process_browsertest.cc#newcode568 content/browser/site_per_process_browsertest.cc:568: main_frame_monitor.ResetEventReceived(); On 2015/10/22 17:17:47, kenrb wrote: > Can we ...
5 years, 2 months ago (2015-10-22 17:20:45 UTC) #4
kenrb
lgtm, although you still need an owner to review.
5 years, 2 months ago (2015-10-22 17:22:36 UTC) #5
lfg
Charlie, please take a look.
5 years, 2 months ago (2015-10-22 17:24:09 UTC) #7
Charlie Reis
Thanks for fixing this! LGTM for OWNERs.
5 years, 2 months ago (2015-10-22 17:48:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416173002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416173002/40001
5 years, 2 months ago (2015-10-22 17:48:57 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-22 17:53:20 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 17:54:22 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9e713e6c00cee68eb7085bdfa17b82c83b47eea6
Cr-Commit-Position: refs/heads/master@{#355577}

Powered by Google App Engine
This is Rietveld 408576698