Reland "Don't report promise rejection events during the microtask checkpoint"

Reland "Don't report promise rejection events during the microtask checkpoint"

Original review https://codereview.chromium.org/1381693002/.

BUG=495801
R=haraken@chromium.org,domenic@chromium.org

Committed: https://crrev.com/2fc1a61d63d5e22eedcf736f78b2747d2ad429b0
Cr-Commit-Position: refs/heads/master@{#355753}

[jochen (gone - plz use gerrit), 2015-10-22 07:00:28]

ptal

what has changed over the original CL is

- merged philip's oilpan fixes
- create a PassRefPtrWillBeRawPtr<> for postTask to avoid UaF
- make m_exception weak when m_promise is weak
- update PromiseRejectinoEventInit.idl to match latest spec

[haraken, 2015-10-22 07:12:26]

LGTM

https://codereview.chromium.org/1416163003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp (right):

https://codereview.chromium.org/1416163003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp:150: return
false;

Add:

  if (!m_scriptState->contextIsValid())
    return false;

https://codereview.chromium.org/1416163003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp:175:
data.GetParameter()->m_collected = true;

m_collected => m_promiseCollected (to make it more explicit that this is for
m_promise, not for m_exception)

[sof, 2015-10-22 07:44:47]

On 2015/10/22 07:00:28, jochen wrote:
> ptal
> 
> what has changed over the original CL is
> 
> - merged philip's oilpan fixes
> - create a PassRefPtrWillBeRawPtr<> for postTask to avoid UaF
> - make m_exception weak when m_promise is weak
> - update PromiseRejectinoEventInit.idl to match latest spec

s/philip/sof/g

[jochen (gone - plz use gerrit), 2015-10-22 08:40:24]

oops, sorry

[jochen (gone - plz use gerrit), 2015-10-22 11:49:29]

https://codereview.chromium.org/1416163003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp (right):

https://codereview.chromium.org/1416163003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp:150: return
false;
On 2015/10/22 at 07:12:26, haraken wrote:
> Add:
> 
>   if (!m_scriptState->contextIsValid())
>     return false;

isCollected() already includes that check

https://codereview.chromium.org/1416163003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp:175:
data.GetParameter()->m_collected = true;
On 2015/10/22 at 07:12:26, haraken wrote:
> m_collected => m_promiseCollected (to make it more explicit that this is for
m_promise, not for m_exception)

it's really for both - promise has a strong link to exception, so they die
together

[jochen (gone - plz use gerrit), 2015-10-23 07:16:15]

Description was changed from

==========
Reland "Don't report promise rejection events during the microtask checkpoint"

Also remove the "required" from the promise in PromiseRejectionEventInit

Original review https://codereview.chromium.org/1381693002/.

BUG=495801
R=haraken@chromium.org,domenic@chromium.org
==========

to

==========
Reland "Don't report promise rejection events during the microtask checkpoint"

Original review https://codereview.chromium.org/1381693002/.

BUG=495801
R=haraken@chromium.org,domenic@chromium.org
==========

[jochen (gone - plz use gerrit), 2015-10-23 07:16:35]

i've split out the idl change

will land that once domenic is back

[jochen (gone - plz use gerrit), 2015-10-23 07:16:39]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-10-23 07:16:40]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1416163003/#ps40001
(title: "updates")

[commit-bot: I haz the power, 2015-10-23 07:17:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1416163003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1416163003/40001

[commit-bot: I haz the power, 2015-10-23 08:46:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-23 08:47:20]

Patchset 3 (id:??) landed as
https://crrev.com/2fc1a61d63d5e22eedcf736f78b2747d2ad429b0
Cr-Commit-Position: refs/heads/master@{#355753}